◐ Shell
reader mode source ↗
Skip to content

bpo-45187: Collect test_socket tests using unittest.#28317

Merged
ambv merged 4 commits into
python:mainfrom
serhiy-storchaka:test-socket
Sep 17, 2021
Merged

bpo-45187: Collect test_socket tests using unittest.#28317
ambv merged 4 commits into
python:mainfrom
serhiy-storchaka:test-socket

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 13, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest.

https://bugs.python.org/issue45187

@serhiy-storchaka
bpo-45187: Collect test_socket tests using unittest. …
58c0815 
Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section needs backport to 3.9 needs backport to 3.10 only security fixes labels Sep 13, 2021
@bedevere-bot

bedevere-bot commented Sep 13, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 58c0815 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 13, 2021
@ambv

ambv commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

The refleaks are real.

@serhiy-storchaka

serhiy-storchaka commented Sep 15, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member Author

Yes, re-ordering tests exposed some issues in tests. They should be fixed in bpo-45212.

@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 16, 2021
@bedevere-bot

bedevere-bot commented Sep 16, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit d3a9a81 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 16, 2021
@serhiy-storchaka

serhiy-storchaka commented Sep 16, 2021

Copy link
Copy Markdown
Member Author

Building on Windows is broken for unknown causes.

@ambv ambv merged commit 0361335 into python:main Sep 17, 2021
@miss-islington

miss-islington commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 0361335b80b435ca3694981b41f8269e390eb892 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 17, 2021
@bedevere-bot

bedevere-bot commented Sep 17, 2021

Copy link
Copy Markdown

GH-28412 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2021
@serhiy-storchaka @miss-islington
bpo-45187: Collect test_socket tests using unittest (pythonGH-28317) …
062c078 
Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest.
(cherry picked from commit 0361335)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@ambv

ambv commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

threading_helper doesn't exist in 3.9, this will need a bit of a different backport. I'll deal with that.

ambv pushed a commit to ambv/cpython that referenced this pull request Sep 17, 2021
@serhiy-storchaka @ambv
[3.9] bpo-45187: Collect test_socket tests using unittest (pythonGH-2… …
99bf749 
…8317)

Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest..
(cherry picked from commit 0361335)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 17, 2021

Copy link
Copy Markdown

GH-28413 is a backport of this pull request to the 3.9 branch.

@serhiy-storchaka serhiy-storchaka deleted the test-socket branch September 17, 2021 10:28
miss-islington added a commit that referenced this pull request Sep 17, 2021
@miss-islington @serhiy-storchaka
bpo-45187: Collect test_socket tests using unittest (GH-28317) …
5a5684a 
Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest.
(cherry picked from commit 0361335)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Sep 17, 2021
@ambv @serhiy-storchaka
[3.9] bpo-45187: Collect test_socket tests using unittest (GH-28317) (G… …
0f4449e 
…H-28413)

Previously, test classes ISOTPTest, J1939Test, BasicUDPLITETest and
UDPLITETimeoutTest were not included in the list of tests and
were not run by regrtest..
(cherry picked from commit 0361335)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ambv ambv

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @bedevere-bot @ambv @miss-islington @the-knights-who-say-ni