◐ Shell
reader mode source ↗
Skip to content

bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing#28377

Merged
ambv merged 4 commits into
python:mainfrom
sobolevn:issue-45209
Sep 21, 2021
Merged

bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing#28377
ambv merged 4 commits into
python:mainfrom
sobolevn:issue-45209

Conversation

@sobolevn

@sobolevn sobolevn commented Sep 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

@vstinner

vstinner commented Sep 16, 2021

Copy link
Copy Markdown
Member

cc @pitrou

@pitrou pitrou changed the title bpo-45209: removes UserWarning: resource_tracker in `test_multiproc… Sep 16, 2021
@sobolevn

sobolevn commented Sep 16, 2021

Copy link
Copy Markdown
Member Author

All PRs right now have this problem: https://dev.azure.com/Python/cpython/_build/results?buildId=87889&view=logs&j=91c152bd-7320-5194-b252-1404e56e2478&t=c7e99cd8-4756-5292-d34b-246ff5fc615f

Another examples:

@vstinner

vstinner commented Sep 16, 2021

Copy link
Copy Markdown
Member

Windows build error on Azure Pipelines is tracked by: https://bugs.python.org/issue45220

@sobolevn

sobolevn commented Sep 18, 2021

Copy link
Copy Markdown
Member Author

Rebased, CI now passes.

vstinner
vstinner approved these changes Sep 20, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. @pitrou: Would you mind to double check this multiprocessing test fix?

I'm kind of unhappy that you have to prepend "/". SharedMemory._prepend_leading_slash does a magic dance (add/remove "/" prefix) with SharedMemory(name) constructor parameter and in SharedMemory.name property. But I don't think that it's worth it to add something just for this very specific test. We can always revisit the code later if we start to have issue on some corner cases.

@sobolevn

sobolevn commented Sep 20, 2021

Copy link
Copy Markdown
Member Author

I'm kind of unhappy that you have to prepend "/". SharedMemory._prepend_leading_slash does a magic dance (add/remove "/" prefix) with SharedMemory(name) constructor parameter and in SharedMemory.name property

Yes, me too. I've tried several other things like smm.name (was not producing the correct result by raising KeyError). After several attempts this was the simplest solution. And since we only run this part on posix, it should work correctly.

Thanks, @vstinner and @pitrou

@ambv

ambv commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Since the slash hack is tests-only, let's have it. We can fix the fix later if we find a way to do so.

@ambv ambv merged commit f604cf1 into python:main Sep 21, 2021
@vstinner vstinner added the needs backport to 3.10 only security fixes label Sep 21, 2021
@miss-islington

miss-islington commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2021
@sobolevn @miss-islington
bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing ( …
0ce2fae 
pythonGH-28377)

(cherry picked from commit f604cf1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Sep 21, 2021

Copy link
Copy Markdown

GH-28499 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 21, 2021
@miss-islington

miss-islington commented Sep 21, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 21, 2021

Copy link
Copy Markdown

GH-28500 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2021
@sobolevn @miss-islington
bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing ( …
8a513df 
pythonGH-28377)

(cherry picked from commit f604cf1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Sep 21, 2021
@miss-islington @sobolevn
bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing ( …
09e5016 
GH-28377)

(cherry picked from commit f604cf1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit that referenced this pull request Sep 21, 2021
@miss-islington @sobolevn
bpo-45209: fix UserWarning: resource_tracker in test_multiprocessing ( …
65268ab 
GH-28377) (GH-28500)

(cherry picked from commit f604cf1)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn @vstinner @ambv @miss-islington @bedevere-bot @pitrou @the-knights-who-say-ni