◐ Shell
reader mode source ↗
Skip to content

bpo-45212: Add a comment for time.sleep() in tests#28414

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test-socket-sleep-comment
Sep 17, 2021
Merged

bpo-45212: Add a comment for time.sleep() in tests#28414
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:test-socket-sleep-comment

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2021

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, thank you. I just suggest to mention the bpo to ease future code reviews.

Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka serhiy-storchaka merged commit 54a1760 into python:main Sep 17, 2021
@serhiy-storchaka serhiy-storchaka deleted the test-socket-sleep-comment branch September 17, 2021 13:20
@vstinner

Copy link
Copy Markdown
Member

Thank you for adding the comment :-)

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

Thanks Łukasz.

niyas-sait pushed a commit to niyas-sait/cpython that referenced this pull request Sep 21, 2021
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants