bpo-45243: Add support for setting/getting sqlite3 connection limits#28463
bpo-45243: Add support for setting/getting sqlite3 connection limits#28463pablogsal merged 16 commits into
sqlite3 connection limits#28463Conversation
|
Thinking about this, I wonder if connection limits are better implemented as attributes: import sqlite3
cx = sqlite3.connect(":memory:")
lim = cx.SQLITE_LIMIT_LENGTH
cx.SQLITE_LIMIT_LENGTH = 100
# instead of
lim = cx.getlimit(sqlite3.SQLITE_LIMIT_LENGTH)
cx.setlimit(sqlite3.SQLITE_LIMIT_LENGTH, 100)I added GH-28790 as an alternative implementation. |
Sorry, something went wrong.
- Use 'category' for limit category - Use 'limit' for the new limit
|
@serhiy-storchaka I changed the argument spec:
I believe this is clearer and more aligned with the SQLite documentation. |
Sorry, something went wrong.
|
@serhiy-storchaka I believe all comments have been resolved. Would you like to take another look at this PR? |
Sorry, something went wrong.
|
@pablogsal would you mind taking a look at this? I believe I've addressed all of Serhiy's comments. |
Sorry, something went wrong.
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged) - Aggregate window functions from python/cpython#20903 - Serialize/deserialize from python/cpython#26728 - Limit setting from python/cpython#28463
https://bugs.python.org/issue45243