◐ Shell
reader mode source ↗
Skip to content

bpo-45292: [PEP 654] add the ExceptionGroup and BaseExceptionGroup classes#28569

Merged
iritkatriel merged 40 commits into
python:mainfrom
iritkatriel:bpo-45292-ExceptionGroup
Oct 22, 2021
Merged

bpo-45292: [PEP 654] add the ExceptionGroup and BaseExceptionGroup classes#28569
iritkatriel merged 40 commits into
python:mainfrom
iritkatriel:bpo-45292-ExceptionGroup

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Sep 26, 2021

Copy link
Copy Markdown
Member

This adds the ExceptionGroup and BaseExceptionGroup classes, but does not yet update the traceback display code to work with them correctly.

https://bugs.python.org/issue45292

@iritkatriel iritkatriel requested a review from a team as a code owner September 26, 2021 14:32
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 26, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c26ff6b38333ab6c990791628f827c5ab97998c2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 26, 2021
@iritkatriel iritkatriel changed the title bpo-45292: [PEP 654] added ExceptionGroup and BaseExceptionGroup (did… Sep 26, 2021
@iritkatriel iritkatriel changed the title bpo-45292: [PEP 654] add ExceptionGroup and BaseExceptionGroup (did… Sep 26, 2021
@iritkatriel iritkatriel changed the title bpo-45292: [PEP 654] add ExceptionGroup and BaseExceptionGroup Sep 26, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c26ff6b38333ab6c990791628f827c5ab97998c2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 26, 2021
@iritkatriel iritkatriel force-pushed the bpo-45292-ExceptionGroup branch from 4907240 to 6c6164a Compare September 26, 2021 18:19
@iritkatriel

Copy link
Copy Markdown
Member Author

This is part 1 - it rebased very easily so not much has changed in the area since April.

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Make sure you run the buildbot for leak checks.

I'd recommend asking for a review from a core dev who is better than me at catching subtle mistakes in C code (Serhiy?).

@iritkatriel

Copy link
Copy Markdown
Member Author

Make sure you run the buildbot for leak checks.

Done.

I'd recommend asking for a review from a core dev who is better than me at catching subtle mistakes in C code (Serhiy?).

Would be great to have a review from @serhiy-storchaka if he's got the time and interest, and also @vstinner and @ncoghlan .

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

(Buffer flush.)

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@iritkatriel, have you managed to convince another core dev to review exceptions.c yet?

@iritkatriel

Copy link
Copy Markdown
Member Author

@iritkatriel, have you managed to convince another core dev to review exceptions.c yet?

Not that I know of.

1 hidden conversation Load more…
@iritkatriel

Copy link
Copy Markdown
Member Author

A PR for the traceback display code is here: iritkatriel#31

Once this PR is merged I will make a PR from that branch into main. But in the meantime it can be reviewed there, diffed against this PR.

5 hidden conversations Load more…
114 hidden items Load more…
@iritkatriel iritkatriel force-pushed the bpo-45292-ExceptionGroup branch from fee53c9 to dbd72d1 Compare October 22, 2021 20:50
@iritkatriel

Copy link
Copy Markdown
Member Author

(rebased)

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 22, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit dbd72d1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the Test PR w/ buildbots; report in status section label Oct 22, 2021
@iritkatriel iritkatriel merged commit f30ad65 into python:main Oct 22, 2021
@gvanrossum

Copy link
Copy Markdown
Member

“And so it begins…”

@1st1

1st1 commented Oct 23, 2021

Copy link
Copy Markdown
Member

@iritkatriel Congrats Irit. This is very impressive work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants