bpo-45292: [PEP 654] add the ExceptionGroup and BaseExceptionGroup classes#28569
bpo-45292: [PEP 654] add the ExceptionGroup and BaseExceptionGroup classes#28569iritkatriel merged 40 commits into
Conversation
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c26ff6b38333ab6c990791628f827c5ab97998c2 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c26ff6b38333ab6c990791628f827c5ab97998c2 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
4907240 to
6c6164a
Compare
September 26, 2021 18:19
|
This is part 1 - it rebased very easily so not much has changed in the area since April. |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
Make sure you run the buildbot for leak checks.
I'd recommend asking for a review from a core dev who is better than me at catching subtle mistakes in C code (Serhiy?).
Sorry, something went wrong.
Done.
Would be great to have a review from @serhiy-storchaka if he's got the time and interest, and also @vstinner and @ncoghlan . |
Sorry, something went wrong.
4b9c502 to
28d458f
Compare
October 1, 2021 18:20
gvanrossum
left a comment
There was a problem hiding this comment.
(Buffer flush.)
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
@iritkatriel, have you managed to convince another core dev to review exceptions.c yet?
Sorry, something went wrong.
Not that I know of. |
Sorry, something went wrong.
|
A PR for the traceback display code is here: iritkatriel#31 Once this PR is merged I will make a PR from that branch into main. But in the meantime it can be reviewed there, diffed against this PR. |
Sorry, something went wrong.
…an error. Tidy up error handling.
fee53c9 to
dbd72d1
Compare
October 22, 2021 20:50
|
(rebased) |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit dbd72d1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
“And so it begins…” |
Sorry, something went wrong.
This adds the ExceptionGroup and BaseExceptionGroup classes, but does not yet update the traceback display code to work with them correctly.
https://bugs.python.org/issue45292