◐ Shell
reader mode source ↗
Skip to content

bpo-31003: IDLE - Add more tests for General tab#2859

Merged
terryjreedy merged 11 commits into
python:masterfrom
terryjreedy:helper
Jul 27, 2017
Merged

bpo-31003: IDLE - Add more tests for General tab#2859
terryjreedy merged 11 commits into
python:masterfrom
terryjreedy:helper

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Jul 25, 2017

Copy link
Copy Markdown
Member

@terryjreedy

Copy link
Copy Markdown
Member Author

WIP: Preparation, now ready to add tests. Each chunk is a coherent diff, and I will try to continue that way.

@terryjreedy

Copy link
Copy Markdown
Member Author

I think this is complete.

@mlouielu mlouielu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I haven't looked deeply to test code, the test pass on Linux.

I have some comment for configdialog.py, some place should be more clarify.

in code and text, matching comment. (CSabella comment).
@terryjreedy terryjreedy merged commit 2bc8f0e into python:master Jul 27, 2017
@terryjreedy terryjreedy deleted the helper branch July 27, 2017 00:54
terryjreedy added a commit to terryjreedy/cpython that referenced this pull request Jul 27, 2017
* In configdialog: Document causal pathways in create_page_general.
Move related functions to follow this. Simplify some attribute names.
* In test_configdialog: Add tests for load and helplist functions.
Coverage for the general tab is now complete, and 63% overall.
(cherry picked from commit 2bc8f0e)
terryjreedy added a commit that referenced this pull request Jul 27, 2017
* In configdialog: Document causal pathways in create_page_general.
Move related functions to follow this. Simplify some attribute names.
* In test_configdialog: Add tests for load and helplist functions.
Coverage for the general tab is now complete, and 63% overall.
(cherry picked from commit 2bc8f0e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants