◐ Shell
reader mode source ↗
Skip to content

gh-89562: Remove hostflags from PySSLContext#28602

Merged
gpshead merged 1 commit into
python:mainfrom
ramikg:remove-hostflags-from-pysslcontext-struct
Apr 18, 2025
Merged

gh-89562: Remove hostflags from PySSLContext#28602
gpshead merged 1 commit into
python:mainfrom
ramikg:remove-hostflags-from-pysslcontext-struct

Conversation

@ramikg

@ramikg ramikg commented Sep 28, 2021 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

The PySSLContext struct in Modules/_ssl.c mentions that "OpenSSL has no API to get hostflags from X509_VERIFY_PARAM* struct. We have to maintain our own copy".
Since OpenSSL 1.1.0i added the function X509_VERIFY_PARAM_get_hostflags, this statement is no longer true.
Because Python 3.10 requires OpenSSL 1.1.1 (PEP 644), we no longer have to maintain a copy of the host flags.

This PR removes the hostflags member from the PySSLContext struct.

https://bugs.python.org/issue45399

@ramikg ramikg changed the title Remove hostflags from PySSLContext Oct 7, 2021
tiran
tiran requested changes Oct 7, 2021
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

bpo-43669 is closed. This PR needs a new ticket.

@bedevere-bot

bedevere-bot commented Oct 7, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ramikg

ramikg commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

@tiran

tiran commented Oct 7, 2021

Copy link
Copy Markdown
Member

bpo-43669 is closed. This PR needs a new ticket.

Is it possible to submit this PR without a bpo? (on the count of it being trivial)

No, this is not a trivial change. Python requires a ticket for every change that has even a remote chance of affecting a single user. By definition, C and OpenSSL are not trivial, too.

@ramikg ramikg changed the title bpo-43669: Remove hostflags from PySSLContext Oct 7, 2021
@ramikg

ramikg commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Understood, thank you.

@ramikg ramikg requested a review from tiran May 28, 2022 11:18
@bedevere-bot

bedevere-bot commented Dec 29, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

1 similar comment
@bedevere-bot

bedevere-bot commented Dec 29, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ramikg

ramikg commented Oct 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented Oct 26, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@python-cla-bot

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@ramikg ramikg requested review from gpshead and picnixz as code owners April 18, 2025 19:32
@ramikg ramikg mannequin mentioned this pull request Apr 18, 2025
Closed
@picnixz picnixz changed the title bpo-45399: Remove hostflags from PySSLContext Apr 18, 2025
@gpshead gpshead merged commit 9752c84 into python:main Apr 18, 2025
@gpshead gpshead self-assigned this Apr 18, 2025
@ramikg ramikg deleted the remove-hostflags-from-pysslcontext-struct branch April 19, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@tiran tiran Awaiting requested review from tiran

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ramikg @bedevere-bot @tiran @gpshead @the-knights-who-say-ni @ezio-melotti