bpo-45337: Use the realpath of the new executable when creating a venv on Windows#28663
bpo-45337: Use the realpath of the new executable when creating a venv on Windows#28663zooba merged 6 commits into
Conversation
…v on Windows. Also warn if the realpath does not match the user-specified location.
|
I triggered the buildbots mainly to test the new one we just added, this PR is still very open for updates :) |
Sorry, something went wrong.
|
I see what you're trying to do here. In fact, I can't find a way to do it any better myself. That being said, I have a (minor) concern. Your introduction of |
Sorry, something went wrong.
Perhaps just documenting explicitly what they're for/why they're used would help, in particular if any other issues in this area come up relating to the MS-Store version of Python. |
Sorry, something went wrong.
I referenced the bug as an example of why we'd need this - unfortunately, this side of things keeps changing on the OS side too often, so I'm very hesitant to pretend in our source code that it's a known thing. Also changed the member name to |
Sorry, something went wrong.
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, something went wrong.
|
Hopefully there were no further concerns. We've got time to fix them up if so |
Sorry, something went wrong.
…v on Windows (pythonGH-28663) (cherry picked from commit 6811fda) Co-authored-by: Steve Dower <steve.dower@python.org>
…v on Windows (pythonGH-28663) (cherry picked from commit 6811fda) Co-authored-by: Steve Dower <steve.dower@python.org>
Also warn if the realpath does not match the user-specified location.
https://bugs.python.org/issue45337