◐ Shell
reader mode source ↗
Skip to content

bpo-45340: Don't create object dictionaries unless actually needed#28802

Merged
markshannon merged 25 commits into
python:mainfrom
faster-cpython:inline-attributes-with-opt
Oct 13, 2021
Merged

bpo-45340: Don't create object dictionaries unless actually needed#28802
markshannon merged 25 commits into
python:mainfrom
faster-cpython:inline-attributes-with-opt

Conversation

@markshannon

@markshannon markshannon commented Oct 7, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

A "normal" Python objects is conceptually just a pair of pointers, one to the class, and one to the dictionary.

With shared keys, the dictionary is redundant as it is no more than a pair of pointers, one to the keys and one to the values.

By adding a pointer to the values to the object and fetching the keys via the class, we can avoid creating a dictionary for many objects.

See faster-cpython/ideas#72 for more details.

About 1% faster, which is nice, but the main benefit is the reduced memory consumption.

https://bugs.python.org/issue45340

@markshannon
Add insertion order bit-vector to dict values to allow dicts to share… …
8214006 
… keys more freely.
@markshannon
Add NEWS
45c9814
@markshannon
Never change types' cached keys. It could invalidate inline attribute… …
c3de09e 
… objects.
@markshannon
Lazily create object dictionaries. Work in progress.
58dd2a0
@markshannon
Restore specialization for inline attributes.
769183a
@markshannon
Turn on stats
1e6cd1f
@markshannon
Fix specialization of LOAD/STORE_ATTR.
a8fbb34
@markshannon
Turn off stats.
37d8cc6
@markshannon
Don't update shared keys version for deletion of value.
0e022f9
@markshannon
Merge main into inline-attributes-with-opt
ddd2e2c
@markshannon
Fix refrence leak.
e979575
@markshannon
Change 'InlineAttribute' to 'InstanceAttribute' as they are not inlin… …
42361ad 
…e (yet)
@markshannon
Merge branch 'main' into inline-attributes-with-opt
e9b09d5
@markshannon
Update gdb support to handle instance values.
70dc34f
@markshannon
Rename SPLIT_KEYS opcodes to INSTANCE_VALUE.
022f2c5
@markshannon
Tidy test_gc
4ec5f11
@markshannon
Don't lose errors.
1818a5a
@markshannon markshannon requested a review from methane as a code owner October 7, 2021 14:31
@markshannon

markshannon commented Oct 7, 2021

Copy link
Copy Markdown
Member Author

Needs NEWS and some additional documentation.

Fidget-Spinner
Fidget-Spinner reviewed Oct 8, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Some comments about LOAD_METHOD.

@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 9, 2021
@bedevere-bot

bedevere-bot commented Oct 9, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 7978220 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 9, 2021
14 hidden items Load more…
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2021
@bedevere-bot

bedevere-bot commented Oct 12, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 8c894f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2021
@markshannon

markshannon commented Oct 13, 2021

Copy link
Copy Markdown
Member Author

The buildbot failures are:

  • buildbot/AMD64 Windows10 PR: Not enough memory on that machine. Lots of MemoryErrors.
  • buildbot/s390x RHEL7 LTO PR: Segfault due to stack overflow. Pre-existing issue (although one that needs fixing if we are going to support s390)
  • buildbot/x86 Gentoo Installed with X PR: Tk issue
  • buildbot/x86 Gentoo Non-Debug with X PR: Tk issue

@markshannon

markshannon commented Oct 13, 2021

Copy link
Copy Markdown
Member Author

Benchmark of final version: 1% faster

@markshannon markshannon merged commit a8b9350 into python:main Oct 13, 2021
@markshannon markshannon mentioned this pull request Dec 2, 2021
Closed
@geryogam geryogam mentioned this pull request May 4, 2022
Merged
@markshannon markshannon mentioned this pull request Nov 29, 2022
Closed
@gertjanvanzwieten gertjanvanzwieten mentioned this pull request Dec 2, 2022
Merged
@markshannon markshannon deleted the inline-attributes-with-opt branch September 26, 2023 12:47
@markshannon markshannon mentioned this pull request Feb 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane left review comments

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @bedevere-bot @methane @Fidget-Spinner @the-knights-who-say-ni