◐ Shell
reader mode source ↗
Skip to content

bpo-45476: Convert PyFloat_AS_DOUBLE() to static inline#28961

Closed
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:macro_as
Closed

bpo-45476: Convert PyFloat_AS_DOUBLE() to static inline#28961
vstinner wants to merge 1 commit into
python:mainfrom
vstinner:macro_as

Conversation

@vstinner

@vstinner vstinner commented Oct 14, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Convert the following macros to static inline functions to disallow
using them as l-value:

  • PyByteArray_AS_STRING()
  • PyBytes_AS_STRING()
  • PyFloat_AS_DOUBLE()

PyUnicode_AS_UNICODE() becomes an alias to PyUnicode_AsUnicode().

https://bugs.python.org/issue45476

@vstinner
bpo-45476: Convert PyFloat_AS_DOUBLE() to static inline …
766c72a 
Convert the following macros to static inline functions to disallow
using them as l-value:

* PyByteArray_AS_STRING()
* PyBytes_AS_STRING()
* PyFloat_AS_DOUBLE()

PyUnicode_AS_UNICODE() becomes an alias to PyUnicode_AsUnicode().
@vstinner vstinner marked this pull request as draft October 15, 2021 00:08
@vstinner

vstinner commented Oct 15, 2021

Copy link
Copy Markdown
Member Author

I convert this PR to a draft since there is disagreement: https://bugs.python.org/issue45476#msg403956

@github-actions

github-actions Bot commented Nov 15, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 15, 2021
@vstinner

vstinner commented Nov 16, 2021

Copy link
Copy Markdown
Member Author

I wrote PEP 670 https://www.python.org/dev/peps/pep-0670/ to decide what's the best approach to fix https://bugs.python.org/issue45476

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 17, 2021
@vstinner

vstinner commented Nov 30, 2021

Copy link
Copy Markdown
Member Author

The PEP 670 is not accepted yet. This PR does two things:

  • (1) disallow using macros as l-value
  • (2) convert macros to static inline functions

Since both changes seem to be controversial, I prefer to limit the change to (1): I wrote the PR #28976 for that. I abandon this PR for now.

Once the (1) change will be done and the PEP 670 will be accepted, it will be non controversial to convert these macros to static inline functions.

For now, I prefer to abandon this PR.

@vstinner vstinner closed this Nov 30, 2021
@vstinner vstinner deleted the macro_as branch November 30, 2021 14:08
@vstinner vstinner mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot