bpo-45502: Fix test_shelve#29003
Conversation
Run test_shelve with all underlying dbm implementations and pickle protocols. Also make test_shelve discoverable.
|
Gentoo buildbot failures unrelated per BPO-45436 (now fixed). Re-running https://buildbot.python.org/all/#/builders/721/builds/50 to see if the segfault is reproducible. Looks related since it's a failure in test_shelve which is the subject of this PR. |
Sorry, something went wrong.
|
Crashed again at same place (in |
Sorry, something went wrong.
|
@pablogsal could you please run this test separately? |
Sorry, something went wrong.
|
I see that tests on this buildbot are ran with option |
Sorry, something went wrong.
This is https://bugs.python.org/issue45289 no? This should be deactivated on the buildbot: |
Sorry, something went wrong.
Sorry, something went wrong.
|
FWIW, I haven't looked much yet into these crashes but I haven't run into them myself yet. I suspect it's an interaction with the Homebrew-installed gdbm which macOS does not ship with. We also don't include gdbm in the python.org macOS binaries. |
Sorry, something went wrong.
|
Since python/buildmaster-config#293 is landed, this can be merged as well. |
Sorry, something went wrong.
|
Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, something went wrong.
|
Sorry, @serhiy-storchaka and @ambv, I could not cleanly backport this to |
Sorry, something went wrong.
|
Sorry @serhiy-storchaka and @ambv, I had trouble checking out the |
Sorry, something went wrong.
Run test_shelve with all underlying dbm implementations and pickle protocols. Also make test_shelve discoverable.. (cherry picked from commit b781cc3) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️Hi! The buildbot AMD64 Arch Linux Asan 3.9 has failed when building commit a043706. What do you need to do:
You can take a look at the buildbot page here: https://buildbot.python.org/all/#builders/579/builds/244 Summary of the results of the build (if available): Click to see traceback logsTraceback (most recent call last):
File "/buildbot/buildarea/3.9.pablogsal-arch-x86_64.asan/build/Lib/multiprocessing/resource_tracker.py", line 201, in main
cache[rtype].remove(name)
KeyError: '/psm_bbb15bda'
|
Sorry, something went wrong.
Run test_shelve with all underlying dbm implementations and pickle protocols.
Also make test_shelve discoverable.
https://bugs.python.org/issue45502