◐ Shell
reader mode source ↗
Skip to content

bpo-45434: Only exclude <stdlib.h> in Python 3.11 limited C API#29027

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:capi_compat
Oct 19, 2021
Merged

bpo-45434: Only exclude <stdlib.h> in Python 3.11 limited C API#29027
vstinner merged 3 commits into
python:mainfrom
vstinner:capi_compat

Conversation

@vstinner

@vstinner vstinner commented Oct 18, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The Python 3.11 limited C API no longer includes stdlib.h, stdio.h,
string.h and errno.h.

  • Exclude Py_MEMCPY() from Python 3.11 limited C API.
  • xxlimited C extension is now built with Python 3.11 limited C API.

https://bugs.python.org/issue45434

@vstinner
bpo-45434: Only exclude <stdlib.h> in Python 3.11 limited C API …
b9dc732 
The Python 3.11 limited C API no longer includes stdlib.h, stdio.h,
string.h and errno.h.

* Exclude Py_MEMCPY() from Python 3.11 limited C API.
* xxlimited C extension is now built with Python 3.11 limited C API.
@vstinner

vstinner commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

@Yhg1s @ronaldoussoren @encukou @tiran: Does it look a reasonable approach to you? Only change the Python 3.11 limited C API, but leave other APIs unchanged?

@ronaldoussoren

ronaldoussoren commented Oct 18, 2021

Copy link
Copy Markdown
Contributor

I not sure if doing this is worth the effort, this makes the headers more complicated and only affects the few extensions that target the stable ABI and want to use API's introduced in 3.11.

@tiran

tiran commented Oct 18, 2021

Copy link
Copy Markdown
Member

I not sure if doing this is worth the effort, this makes the headers more complicated and only affects the few extensions that target the stable ABI and want to use API's introduced in 3.11.

I think it's worth doing. In the long run it's going to make Python.h lean and mean.

@vstinner

vstinner commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

@tiran: I addresssed your review.

@vstinner

vstinner commented Oct 18, 2021

Copy link
Copy Markdown
Member Author

I not sure if doing this is worth the effort, this makes the headers more complicated and only affects the few extensions that target the stable ABI and want to use API's introduced in 3.11.

You only have to do this update work once. Once you added the missing #include, the code remains compatible with older Python versions, and becomes "future proof" (no need to add again these include).

@vstinner vstinner merged commit 52af075 into python:main Oct 19, 2021
@vstinner vstinner deleted the capi_compat branch October 19, 2021 10:10
@encukou encukou mentioned this pull request Feb 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @ronaldoussoren @tiran @the-knights-who-say-ni @bedevere-bot