◐ Shell
reader mode source ↗
Skip to content

bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1)#2905

Merged
terryjreedy merged 10 commits into
python:masterfrom
csabella:bpo31004
Jul 30, 2017
Merged

bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1)#2905
terryjreedy merged 10 commits into
python:masterfrom
csabella:bpo31004

Conversation

@csabella

@csabella csabella commented Jul 27, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

terryjreedy
terryjreedy reviewed Jul 28, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks fine so far. My comments are mostly about looking ahead to the next two steps to anticipate possible problems.

terryjreedy
terryjreedy approved these changes Jul 30, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please test on *nix. Otherwise, I believe this is ready to merge.

@csabella

csabella commented Jul 30, 2017

Copy link
Copy Markdown
Contributor Author

Looks on good Ubuntu. Ran the testsuite and the htests.

@terryjreedy terryjreedy merged commit 9397e2a into python:master Jul 30, 2017
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jul 30, 2017
@csabella @terryjreedy
[3.6] bpo-31004: IDLE: Factor out FontPage class from configdialog (s… …
82fe34e 
…tep 1) (pythonGH-2905)

The slightly modified tests continue to pass. The General test
broken by the switch to Notebook is fixed.
Patch mostly by Cheryl Sabella.
(cherry picked from commit 9397e2a)
@terryjreedy terryjreedy mentioned this pull request Jul 30, 2017
Merged
terryjreedy added a commit that referenced this pull request Jul 30, 2017
@terryjreedy
[3.6] bpo-31004: IDLE: Factor out FontPage class from configdialog (s… …
7582226 
…tep 1) (GH-2905) (#2950)

The slightly modified tests continue to pass. The General test
broken by the switch to Notebook is fixed.
Patch mostly by Cheryl Sabella.
(cherry picked from commit 9397e2a)
@csabella csabella deleted the bpo31004 branch July 30, 2017 19:32
@mlouielu

mlouielu commented Aug 1, 2017

Copy link
Copy Markdown
Contributor

Test on MacOS, works well.

@terryjreedy

terryjreedy commented Aug 1, 2017

Copy link
Copy Markdown
Member

Thanks for the Mac test. That should tests everything prior to this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

+1 more reviewer

@mlouielu mlouielu

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csabella @mlouielu @terryjreedy @the-knights-who-say-ni