◐ Shell
reader mode source ↗
Skip to content

Experimental variant of BINARY_ADD specialization.#29059

Closed
markshannon wants to merge 4 commits into
python:mainfrom
faster-cpython:alternative-specialize-binary-add
Closed

Experimental variant of BINARY_ADD specialization.#29059
markshannon wants to merge 4 commits into
python:mainfrom
faster-cpython:alternative-specialize-binary-add

Conversation

@markshannon

@markshannon markshannon commented Oct 19, 2021

Copy link
Copy Markdown
Member

No description provided.

Fidget-Spinner
Fidget-Spinner reviewed Oct 19, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I wonder if we'll see any speedups from this. I don't see how it will be much faster than PyNumber_Add. If the compiler's smart about it, it'll probably inline PyNumber_Add during PGO, and we'll have almost the same function

@markshannon

markshannon commented Oct 19, 2021

Copy link
Copy Markdown
Member Author

Disappointing results

@markshannon

markshannon commented Nov 10, 2021

Copy link
Copy Markdown
Member Author

Will need reworking once #29482 is merged.

@markshannon

markshannon commented Nov 16, 2021

Copy link
Copy Markdown
Member Author

@brandtbucher Maybe something like this will show better results now that the binary and inplace operators have been merged?

@markshannon markshannon deleted the alternative-specialize-binary-add branch September 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@brandtbucher brandtbucher brandtbucher left review comments

Assignees

No one assigned

Labels

DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @Fidget-Spinner @brandtbucher @the-knights-who-say-ni @bedevere-bot