◐ Shell
reader mode source ↗
Skip to content

bpo-45566: test_frozen_pickle checks all pickle protocols#29150

Merged
miss-islington merged 2 commits into
python:mainfrom
sobolevn:issue-45566
Oct 24, 2021
Merged

bpo-45566: test_frozen_pickle checks all pickle protocols#29150
miss-islington merged 2 commits into
python:mainfrom
sobolevn:issue-45566

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 22, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue45566

Refs #29147

Automerge-Triggered-By: GH:ericvsmith

@sobolevn sobolevn requested a review from ericvsmith as a code owner October 22, 2021 09:06
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 22, 2021
@bedevere-bot

bedevere-bot commented Oct 24, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@sobolevn

sobolevn commented Oct 24, 2021

Copy link
Copy Markdown
Member Author

Thanks, @ericvsmith!

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Oct 24, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

@miss-islington

miss-islington commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

@sobolevn: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 07236d5 into python:main Oct 24, 2021
@miss-islington

miss-islington commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2021
@sobolevn @miss-islington
bpo-45566: test_frozen_pickle checks all pickle protocols (python… …
a85231d 
…GH-29150)

Refs python#29147

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit 07236d5)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Oct 24, 2021

Copy link
Copy Markdown

GH-29201 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 24, 2021
@miss-islington

miss-islington commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 07236d562e59c6650227be18fa6ffc66b18d4741 3.9

@miss-islington miss-islington self-assigned this Oct 24, 2021
miss-islington added a commit that referenced this pull request Oct 24, 2021
@miss-islington @sobolevn
bpo-45566: test_frozen_pickle checks all pickle protocols (GH-29150) …
36971fd 
Refs #29147

Automerge-Triggered-By: GH:ericvsmith
(cherry picked from commit 07236d5)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@miss-islington miss-islington

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @bedevere-bot @miss-islington @ericvsmith @the-knights-who-say-ni