◐ Shell
reader mode source ↗
Skip to content

bpo-37658: Actually return result in race condition#29202

Merged
asvetlov merged 6 commits into
python:mainfrom
Dreamsorcerer:patch-5
Nov 29, 2021
Merged

bpo-37658: Actually return result in race condition#29202
asvetlov merged 6 commits into
python:mainfrom
Dreamsorcerer:patch-5

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Oct 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Splitting this out from #28149 to ease review.

The original test written for this issue is bogus and fails to reproduce the bug report. I've replaced it with a test that reproduces the error, and have actually fixed the problem reported.

https://bugs.python.org/issue37658

@Dreamsorcerer Dreamsorcerer changed the title bpo-37658: Actually fix the problem Oct 24, 2021
@github-actions

github-actions Bot commented Nov 25, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Nov 25, 2021
asvetlov
asvetlov requested changes Nov 28, 2021
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The PR is correct.

Please add a NEWS entry.

@bedevere-bot

bedevere-bot commented Nov 28, 2021

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Dreamsorcerer

Dreamsorcerer commented Nov 28, 2021

Copy link
Copy Markdown
Contributor Author

I couldn't run the blurb add command that seemed to be suggested, but I think that's right.

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Nov 28, 2021

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Nov 29, 2021
@asvetlov

asvetlov commented Nov 29, 2021

Copy link
Copy Markdown
Contributor

Thanks!

@asvetlov asvetlov merged commit 934a826 into python:main Nov 29, 2021
@miss-islington

miss-islington commented Nov 29, 2021

Copy link
Copy Markdown
Contributor

Thanks @Dreamsorcerer for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 29, 2021

Copy link
Copy Markdown

GH-29832 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2021
@Dreamsorcerer @miss-islington
bpo-37658: Actually return result in race condition (pythonGH-29202) …
6209eff 
(cherry picked from commit 934a826)

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2021
@Dreamsorcerer @miss-islington
bpo-37658: Actually return result in race condition (pythonGH-29202) …
3d05d91 
(cherry picked from commit 934a826)

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@bedevere-bot

bedevere-bot commented Nov 29, 2021

Copy link
Copy Markdown

GH-29831 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 29, 2021
miss-islington added a commit that referenced this pull request Nov 29, 2021
@miss-islington @Dreamsorcerer
bpo-37658: Actually return result in race condition (GH-29202) …
305236e 
(cherry picked from commit 934a826)

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
asvetlov pushed a commit that referenced this pull request Nov 30, 2021
@miss-islington @Dreamsorcerer
bpo-37658: Actually return result in race condition (GH-29202) (GH-29832 …
99a9b34 
)

(cherry picked from commit 934a826)

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@NikitaIlyasov NikitaIlyasov mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

+1 more reviewer

@aaliddell aaliddell aaliddell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Dreamsorcerer @bedevere-bot @asvetlov @miss-islington @aaliddell @the-knights-who-say-ni