bpo-10572: Move `sqlite3` tests to `Lib/test`#29304

erlend-aasland

https://bugs.python.org/issue10572

Automerge-Triggered-By: GH:brettcannon

deleted Lib/sqlite3/test/__init__.py renamed /test/test_sqlite.py -> Lib/test/test_sqlite3/__init__.py renamed /sqlite3/test/test_backup.py -> Lib/test/test_sqlite3/test_backup.py renamed /sqlite3/test/test_dbapi.py -> Lib/test/test_sqlite3/test_dbapi.py renamed /sqlite3/test/test_dump.py -> Lib/test/test_sqlite3/test_dump.py renamed /sqlite3/test/test_factory.py -> Lib/test/test_sqlite3/test_factory.py renamed /sqlite3/test/test_hooks.py -> Lib/test/test_sqlite3/test_hooks.py renamed /sqlite3/test/test_regression.py -> Lib/test/test_sqlite3/test_regression.py renamed /sqlite3/test/test_transactions.py -> Lib/test/test_sqlite3/test_transactions.py renamed /sqlite3/test/test_types.py -> Lib/test/test_sqlite3/test_types.py renamed /sqlite3/test/test_userfunctions.py -> Lib/test/test_sqlite3/test_userfunctions.py

erlend-aasland

After Serhiy's eminent cleanup in commit 3e19409, the main argument against moving the tests is now moot. Thanks to Serhiy's cleanup, moving the tests is now a much smaller PR than the previous attempt (GH-24148).

bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-authored-by: Brett Cannon <brett@python.org>

This reverts commit 35f6334 and adds a comment on why it was needed

erlend-aasland

I believe I have made the requested changes; please review again.

bedevere-bot

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

brettcannon

It all LGTM, I just want to double-check the tests still run, so I'm waiting on CI to finish at least one of the test runs. 😄

miss-islington

@erlend-aasland: Status check is done, and it's a failure ❌ .

miss-islington

@erlend-aasland: Status check is done, and it's a success ✅ .

erlend-aasland

Thanks, Brett!

bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 Pro 3.x has failed when building commit 62bf263.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/596/builds/1321) and take a look at the build logs.
Check if the failure is related to this commit (62bf263) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/596/builds/1321

Failed tests:

test_os
test_regrtest

Failed subtests:

test_walk_bad_dir - test.test_os.BytesWalkTests

Summary of the results of the build (if available):

== Tests result: FAILURE then SUCCESS ==

395 tests OK.

10 slowest tests:

test_multiprocessing_spawn: 2 min 43 sec
test_peg_generator: 2 min 27 sec
test_unparse: 1 min 59 sec
test_concurrent_futures: 1 min 48 sec
test_tokenize: 1 min 39 sec
test_asyncio: 1 min 19 sec
test_lib2to3: 1 min 14 sec
test_unicodedata: 1 min 6 sec
test_distutils: 1 min 6 sec
test_capi: 1 min 5 sec

34 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_tix test_tk test_ttk_guionly
test_wait3 test_wait4 test_xxlimited test_xxtestfuzz
test_zipfile64

2 re-run tests:
test_os test_regrtest

1 test run no tests:
test_regrtest

Total duration: 15 min 30 sec

Click to see traceback logs

Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 396, in temp_dir
    yield path
    ^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 449, in temp_cwd
    yield cwd_dir
    ^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 658, in main
    self._main(tests, kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 731, in _main
    sys.exit(0)
    ^^^^^^^^^^^
SystemExit: 0


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\__init__.py", line 197, in _force_run
    return func(*args)
           ^^^^^^^^^^^
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'C:\\buildbot.python.org\\3.x.kloth-win64\\build\\build\\test_python_8352�\\test_python_worker_7008�'


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
    ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\__main__.py", line 2, in <module>
    main()
    ^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 736, in main
    Regrtest().main(tests=tests, **kwargs)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\libregrtest\main.py", line 652, in main
    with os_helper.temp_cwd(test_cwd, quiet=True):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 447, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\contextlib.py", line 155, in __exit__
    self.gen.throw(typ, value, traceback)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 401, in temp_dir
    rmtree(path)
    ^^^^^^^^^^^^
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\support\os_helper.py", line 358, in rmtree


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_os.py", line 1428, in test_walk_bad_dir
    os.rename(path1, path1new)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^
PermissionError: [WinError 5] Access is denied: '@test_12176_tmp�\\TEST1\\SUB1' -> '@test_12176_tmp�\\TEST1\\SUB1.new'

erlend-aasland

See GH-29327 for the buildbot fix.

erlend-aasland

We should consider mentioning this change in the 3.11 What's New document. Re #94998.

erlend-aasland

Proposed What's New entry in gh-95059.

Erlend E. Aasland added 5 commits October 29, 2021 09:52

Fixup Lib/test/test_sqlite3/__init__.py

1333aa9

Add NEWS

f5f1bde

Update Makefile

195709a

Fix inter-test includes

571a515

erlend-aasland requested a review from berkerpeksag as a code owner October 29, 2021 08:12

the-knights-who-say-ni added the CLA signed label Oct 29, 2021

bedevere-bot added the awaiting review label Oct 29, 2021

erlend-aasland requested a review from brettcannon October 29, 2021 08:15

Erlend E. Aasland added 2 commits October 29, 2021 10:43

Fixup PCbuild

351dcae

Revert 571a515

f8889d2

erlend-aasland requested a review from a team as a code owner October 29, 2021 08:45

Erlend E. Aasland added 3 commits October 29, 2021 10:49

Allow ./python -m test.test_sqlite3

b6f50d9

Fixup __init__.py debug message

cbb18a9

Simplify __init__

7f2ee3b

brettcannon requested changes Oct 29, 2021

View reviewed changes

bedevere-bot removed the awaiting review label Oct 29, 2021

bedevere-bot added the awaiting changes label Oct 29, 2021

Erlend Egeberg Aasland and others added 5 commits October 29, 2021 22:20

Update Lib/test/test_sqlite3/__main__.py …

bca9a72

Co-authored-by: Brett Cannon <brett@python.org>

Address review: remove useless import

35f6334

Revert "Address review: remove useless import" …

52b9164

This reverts commit 35f6334 and adds a comment on why it was needed

Address review: remove uneeded 'if __name__ == "__main__"'

5d5e84f

Add comment and clean up __init__

75fe05b

bedevere-bot added awaiting change review and removed awaiting changes labels Oct 29, 2021

bedevere-bot requested a review from brettcannon October 29, 2021 21:09

brettcannon reviewed Oct 29, 2021

View reviewed changes

brettcannon added 3 commits October 29, 2021 14:44

Add a period

76b8533

Add a period

200d2fc

Add a period

f0b13eb

brettcannon self-requested a review October 29, 2021 21:45

brettcannon approved these changes Oct 29, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Oct 29, 2021

brettcannon added the 🤖 automerge label Oct 29, 2021

miss-islington merged commit 62bf263 into python:main Oct 29, 2021

bedevere-bot removed the awaiting merge label Oct 29, 2021

erlend-aasland deleted the sqlite-move-tests branch October 29, 2021 22:08

voidspace mentioned this pull request Jun 20, 2022

Move test sub-packages to Lib/test #54781

Closed

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 20, 2022

[3.11] pythongh-29304: Mention sqlite3 test relocation in What's New

c8c7f3e

zware mentioned this pull request Jul 20, 2022

[3.11] gh-54781: Relocate and improve NEWS entry for sqlite3 test relocation #95061

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-10572: Move `sqlite3` tests to `Lib/test`#29304

bpo-10572: Move `sqlite3` tests to `Lib/test`#29304
miss-islington merged 18 commits into
python:mainfrom
erlend-aasland:sqlite-move-tests

erlend-aasland commented Oct 29, 2021 •

edited by miss-islington

Loading

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

Uh oh!

brettcannon commented Oct 29, 2021

Uh oh!

miss-islington commented Oct 29, 2021

Uh oh!

miss-islington commented Oct 29, 2021

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

erlend-aasland commented Jul 19, 2022 •

edited

Loading

Uh oh!

erlend-aasland commented Jul 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

erlend-aasland commented Oct 29, 2021 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

Uh oh!

brettcannon commented Oct 29, 2021

Uh oh!

miss-islington commented Oct 29, 2021

Uh oh!

miss-islington commented Oct 29, 2021

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

bedevere-bot commented Oct 29, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

erlend-aasland commented Oct 29, 2021

Uh oh!

erlend-aasland commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Jul 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erlend-aasland commented Oct 29, 2021 •

edited by miss-islington

Loading

erlend-aasland commented Jul 19, 2022 •

edited

Loading