◐ Shell
reader mode source ↗
Skip to content

bpo-45678: Add functools.singledispatchmethod tests#29328

Merged
ambv merged 2 commits into
python:mainfrom
AlexWaygood:add-functools-tests
Nov 3, 2021
Merged

bpo-45678: Add functools.singledispatchmethod tests#29328
ambv merged 2 commits into
python:mainfrom
AlexWaygood:add-functools-tests

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 30, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 30, 2021
@ambv ambv added needs backport to 3.9 needs backport to 3.10 only security fixes 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Nov 2, 2021
@bedevere-bot

bedevere-bot commented Nov 2, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit 3767676 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 2, 2021
@AlexWaygood

AlexWaygood commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

All buildbot failures but one are on test_sqlite3. I believe that is unrelated to this PR (see #29382).

The only buildbot that failed on a non-sqlite test was "AMD64 FreeBSD Shared PR", where test_gdb didn't pass. I think that's probably also unrelated? 🙂

@ambv ambv merged commit 5a14929 into python:main Nov 3, 2021
@miss-islington

miss-islington commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood @miss-islington
bpo-45678: Add functools.singledispatchmethod tests (pythonGH-29328) …
9c41894 
(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29390 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 3, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood @miss-islington
bpo-45678: Add functools.singledispatchmethod tests (pythonGH-29328) …
531de96 
(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot

bedevere-bot commented Nov 3, 2021

Copy link
Copy Markdown

GH-29391 is a backport of this pull request to the 3.9 branch.

@AlexWaygood AlexWaygood deleted the add-functools-tests branch November 3, 2021 16:13
ambv pushed a commit that referenced this pull request Nov 3, 2021
@miss-islington @AlexWaygood
bpo-45678: Add functools.singledispatchmethod tests (GH-29328) (G… …
f191838 
…H-29390)

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 3, 2021
@AlexWaygood
[3.9] bpo-45678: Fix singledispatchmethod classmethod/`staticmeth… …
fdff8bf 
…od` bug

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and
python#29390.
@AlexWaygood AlexWaygood mentioned this pull request Nov 3, 2021
Merged
@AlexWaygood

AlexWaygood commented Nov 3, 2021

Copy link
Copy Markdown
Member Author

As discussed in #29391, the attempted backport of this PR by @miss-islington to Python 3.9 exposed a bug in that branch. A new bugfix/backport PR is here: #29394

ambv added a commit that referenced this pull request Nov 4, 2021
@AlexWaygood @ambv
[3.9] bpo-45678: Fix singledispatchmethod classmethod/`staticmeth… …
effb72f 
…od` bug (GH-29394)

This PR fixes a bug in the 3.9 branch where
``functools.singledispatchmethod`` did not properly wrap attributes such as
``__name__``, ``__doc__`` and ``__module__`` of the target method. It also
backports tests already merged into the 3.11 and 3.10 branches in #29328 and
#29390.

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Labels

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexWaygood @bedevere-bot @miss-islington @ambv @the-knights-who-say-ni