◐ Shell
reader mode source ↗
Skip to content

bpo-39026: Fix Python.h when building with Xcode#29488

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_include
Nov 23, 2021
Merged

bpo-39026: Fix Python.h when building with Xcode#29488
vstinner merged 1 commit into
python:mainfrom
vstinner:fix_include

Conversation

@vstinner

@vstinner vstinner commented Nov 9, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Fix Python.h to build C extensions with Xcode: remove a relative
include from Include/cpython/pystate.h.

https://bugs.python.org/issue39026

@vstinner
bpo-39026: Fix Python.h when building with Xcode …
69f004f 
Fix Python.h to build C extensions with Xcode: remove a relative
include from Include/cpython/pystate.h.
@vstinner vstinner mentioned this pull request Nov 9, 2021
Closed
@vstinner

vstinner commented Nov 9, 2021

Copy link
Copy Markdown
Member Author

Fix Python.h to build C extensions with Xcode

I'm not sure if the problem is Xcode or "developing with a framework in macOS".

@vstinner vstinner merged commit 4ae26b9 into python:main Nov 23, 2021
@vstinner vstinner deleted the fix_include branch November 23, 2021 17:58
@miss-islington

miss-islington commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4ae26b9c1d0c33e3db92c6f305293f9240dea358 3.10

@miss-islington

miss-islington commented Nov 23, 2021

Copy link
Copy Markdown
Contributor

Sorry @vstinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4ae26b9c1d0c33e3db92c6f305293f9240dea358 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 23, 2021
@bedevere-bot

bedevere-bot commented Nov 23, 2021

Copy link
Copy Markdown

GH-29732 is a backport of this pull request to the 3.10 branch.

@tiran tiran mentioned this pull request Nov 23, 2021
Merged
vstinner added a commit that referenced this pull request Nov 25, 2021
@vstinner
bpo-39026: Fix Python.h when building with Xcode (GH-29488) (GH-29732) …
ce5a646 
Fix Python.h to build C extensions with Xcode: remove a relative
include from Include/cpython/pystate.h.

(cherry picked from commit 4ae26b9)
vstinner added a commit that referenced this pull request Nov 26, 2021
@vstinner
bpo-39026: Fix Python.h when building with Xcode (GH-29488) (GH-29776) …
92631a4 
Fix Python.h to build C extensions with Xcode: remove a relative
include from Include/cpython/pystate.h.

(cherry picked from commit 4ae26b9)
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@vstinner @remykarem
bpo-39026: Fix Python.h when building with Xcode (pythonGH-29488) …
bf0e95e 
Fix Python.h to build C extensions with Xcode: remove a relative
include from Include/cpython/pystate.h.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni