◐ Shell
reader mode source ↗
Skip to content

gh-89928: consume dev_t with PyLong_FromUnsignedLongLong#29494

Closed
AMDmi3 wants to merge 1 commit into
python:mainfrom
AMDmi3:patch-1
Closed

gh-89928: consume dev_t with PyLong_FromUnsignedLongLong#29494
AMDmi3 wants to merge 1 commit into
python:mainfrom
AMDmi3:patch-1

Conversation

@AMDmi3

@AMDmi3 AMDmi3 commented Nov 9, 2021 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Dec 10, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 10, 2021
@kumaraditya303

kumaraditya303 commented Jan 20, 2022

Copy link
Copy Markdown
Contributor

Can you add a news entry ? https://blurb-it.herokuapp.com/

@AMDmi3

AMDmi3 commented Jan 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Can you add a news entry ? https://blurb-it.herokuapp.com/

Sure, done. Also added GH pull request number to summary and rebased.

@MaxwellDupre

MaxwellDupre commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

I dont see the following:
#if defined(__FreeBSD__) #define DEVICE_MAJORMINOR_T int #else #define DEVICE_MAJORMINOR_T unsigned int #endif
In your Files changed, please explain?

@AMDmi3

AMDmi3 commented Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

I dont see the following:

Because it's not there, obviously. This PR only addresses one aspect of the problem.

MaxwellDupre
MaxwellDupre approved these changes Apr 18, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks ok.

@erlend-aasland erlend-aasland changed the title bpo-45767: consume dev_t with PyLong_FromUnsignedLongLong Jan 5, 2024
@AMDmi3 AMDmi3 mannequin mentioned this pull request Mar 28, 2024
Closed
@serhiy-storchaka

serhiy-storchaka commented Jun 4, 2024

Copy link
Copy Markdown
Member

Thank you for your contribution, but more complex #31794 was merged instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AMDmi3 @kumaraditya303 @MaxwellDupre @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot