{{ message }}
bpo-31050: IDLE: Factor GenPage class from ConfigDialog#2952
Merged
terryjreedy merged 2 commits intoJul 30, 2017
Merged
Conversation
Contributor
Sorry, something went wrong.
terryjreedy
requested changes
Jul 30, 2017
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
Add blurb with
bpo-31004: Factor FontPage(Frame) class from ConfigDialog.
The slightly modified tests continue to pass.
Patch by Cheryl Sabella.
Sorry, something went wrong.
terryjreedy
reviewed
Jul 30, 2017
terryjreedy
approved these changes
Jul 30, 2017
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
I tested each widget on the page and checked that the corresponding change had been made in my user config-main. (Automating this would be the subject of a #24845 spinoff.)
Sorry, something went wrong.
terryjreedy
changed the title
terryjreedy
added a commit
that referenced
this pull request
Jul 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue31050