◐ Shell
reader mode source ↗
Skip to content

bpo-45834: Move runtime 'except:' check to the parser#29625

Closed
pablogsal wants to merge 1 commit into
python:mainfrom
pablogsal:bpo-45834
Closed

bpo-45834: Move runtime 'except:' check to the parser#29625
pablogsal wants to merge 1 commit into
python:mainfrom
pablogsal:bpo-45834

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 18, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@iritkatriel

iritkatriel commented Nov 19, 2021

Copy link
Copy Markdown
Member

LGTM based on the tests but I’m not a good reviewer for the parser.

lysnikolaou
lysnikolaou approved these changes Nov 20, 2021
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

@iritkatriel

iritkatriel commented Dec 13, 2021

Copy link
Copy Markdown
Member

Let's close this if it's not worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel

@isidentical isidentical isidentical left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @iritkatriel @lysnikolaou @isidentical @the-knights-who-say-ni @bedevere-bot