bpo-45873: Restore Python 3.6 compatibility (GH-29730)#29730
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
LGTM, but is it even worth testing for 3.7+? Why not always take the slow path?
Sorry, something went wrong.
I left the old implementation in because it's more readable. The fast path is now in a doc string for future reference. I also added more debug code to configure to figure out what is going on on the Debian buildbot. |
Sorry, something went wrong.
|
Closing and reopening to retrigger Azure. |
Sorry, something went wrong.
gvanrossum
left a comment
There was a problem hiding this comment.
(Why do we even bother with "python3 python"? For weird platforms that have only one of those but it happens to be 3.6 or better?)
Sorry, something went wrong.
I don't know and kept |
Sorry, something went wrong.
Sorry, something went wrong.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
gvanrossum
left a comment
There was a problem hiding this comment.
:-)
Sorry, something went wrong.
How? That PR was closed without merging. And if there was a cause outside this PR why would it not have failed before (e.g. when I submitted #29717)? Are you suggesting there are some cached files from running that PR present? |
Sorry, something went wrong.
Co-authored-by: Guido van Rossum <gvanrossum@gmail.com>
https://bugs.python.org/issue45873
Automerge-Triggered-By: GH:tiran