◐ Shell
reader mode source ↗
Skip to content

bpo-45711: [asyncio] Normalize exceptions immediately after Fetch, before they are stored as StackItem, which should be normalized#29890

Merged
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:45711-exc_info_does_not_need_normalizing
Dec 3, 2021
Merged

bpo-45711: [asyncio] Normalize exceptions immediately after Fetch, before they are stored as StackItem, which should be normalized#29890
iritkatriel merged 5 commits into
python:mainfrom
iritkatriel:45711-exc_info_does_not_need_normalizing

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Dec 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

The handled exception exc_info (unlike the in-flight exception currexc) is always normalized. Except in asyncio, where unnormalised exceptions are saved in a StackItem and need to be normalized when they are used.

This PR brings asyncio in line with the rest of the code, by normalising exceptions and setting the traceback when they are Fetched.

https://bugs.python.org/issue45711

@iritkatriel iritkatriel requested a review from cjerdonek December 2, 2021 12:37
@bedevere-bot bedevere-bot added the label Dec 2, 2021
@iritkatriel iritkatriel marked this pull request as draft December 2, 2021 13:12
@iritkatriel

iritkatriel commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

This broke a couple of the asyncio tests, I'm checking why.

@iritkatriel

iritkatriel commented Dec 2, 2021

Copy link
Copy Markdown
Member Author

This broke a couple of the asyncio tests, I'm checking why.

Right, because I removed the traceback update, which is not part of the normalising. The tests pass if I put it back.

But I think the right place to do this is when the exception is captured, here

cpython/Modules/_asynciomodule.c

Line 2705 in cb8f491

@iritkatriel iritkatriel requested a review from asvetlov December 2, 2021 16:27
@iritkatriel iritkatriel changed the title bpo-45711: Remove unnecessary normalization of exc_info Dec 2, 2021
@iritkatriel iritkatriel marked this pull request as ready for review December 2, 2021 17:27
@iritkatriel iritkatriel requested a review from 1st1 as a code owner December 2, 2021 17:27
gvanrossum
gvanrossum approved these changes Dec 3, 2021
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LG from me, not sure how long to wait for @1st1.

@iritkatriel iritkatriel merged commit 2ff758b into python:main Dec 3, 2021
@iritkatriel iritkatriel deleted the 45711-exc_info_does_not_need_normalizing branch December 8, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov asvetlov approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@cjerdonek cjerdonek Awaiting requested review from cjerdonek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @1st1 @asvetlov @gvanrossum @the-knights-who-say-ni @bedevere-bot