◐ Shell
reader mode source ↗
Skip to content

bpo-20907: shutil._unpack_zipfile add warnings for skipped files#29910

Open
akulakov wants to merge 8 commits into
python:mainfrom
akulakov:20907-unpack_zipfile-add-warnings-for-skipped-files
Open

bpo-20907: shutil._unpack_zipfile add warnings for skipped files#29910
akulakov wants to merge 8 commits into
python:mainfrom
akulakov:20907-unpack_zipfile-add-warnings-for-skipped-files

Conversation

@akulakov

@akulakov akulakov commented Dec 4, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Note that test zip only has a '..' path component for testing, and no absolute path. My zip archiver (as well as Python zip archiver) do not create absolute paths. It seems like all (?) modern zip archivers don't create absolute paths. If someone knows of an easy way to add such a path to the test zip file, I can update the unit test for that.

https://bugs.python.org/issue20907

@akulakov

akulakov commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

I've updated to use logging.warning, @merwok @ambv please take a look if you have time..

MaxwellDupre
MaxwellDupre approved these changes Apr 15, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Ran 164 tests in 2.291s
OK (skipped=24)
Looks ok.

@peterpsantoronet peterpsantoronet mannequin mentioned this pull request Apr 10, 2022
Open
@serhiy-storchaka

serhiy-storchaka commented Dec 16, 2023

Copy link
Copy Markdown
Member

See also #111824 which fixes the original issue in a different way.

@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale label Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments

@merwok merwok merwok left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

+1 more reviewer

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@akulakov @serhiy-storchaka @ambv @merwok @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot