◐ Shell
reader mode source ↗
Skip to content

bpo-45774: Harden SQLite detection#30016

Merged
tiran merged 9 commits into
python:mainfrom
erlend-aasland:ac-harden-sqlite-detection
Apr 5, 2022
Merged

bpo-45774: Harden SQLite detection#30016
tiran merged 9 commits into
python:mainfrom
erlend-aasland:ac-harden-sqlite-detection

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 9, 2021 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor
  • Beautify configure output
  • Make sure vital functions are in place

https://bugs.python.org/issue45774

Automerge-Triggered-By: GH:tiran

bpo-45774: Harden SQLite detection …
8fdd805 
- Beautify configure output
- Make sure vital functions are in place
@erlend-aasland erlend-aasland requested a review from tiran December 9, 2021 22:37
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@bedevere-bot

bedevere-bot commented Dec 10, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit f5b0552 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 10, 2021
@erlend-aasland

erlend-aasland commented Dec 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Regarding the buildbot run: SQLite is correctly detected and the sqlite3 module is built, AFAICS. The two failures seem to be unrelated.

@erlend-aasland

erlend-aasland commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

@tiran, are you ok with this PR? For those of us who've got multiple SQLite installations with completely different configurations, it's nice to fail early with configure rather than wait for a link error at the end of compilation.

@erlend-aasland

erlend-aasland commented Jan 5, 2022

Copy link
Copy Markdown
Contributor Author

Regarding the buildbot run:

  • AMD64 Arch Linux ASAN failed at test_multiprocessing_fork
  • PPC64LE RHEL7 Refleaks failed at test_typing

Both failures are unrelated to this PR.

@erlend-aasland

erlend-aasland commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

@tiran: 🏓

@erlend-aasland erlend-aasland mentioned this pull request Mar 4, 2022
Merged
@erlend-aasland erlend-aasland requested a review from gpshead March 4, 2022 20:17
gpshead
gpshead approved these changes Mar 4, 2022
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library. But if they do, this likely does a better job at detecting that and avoiding it.

@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2022
@bedevere-bot

bedevere-bot commented Mar 4, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit e8558da 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 4, 2022
@erlend-aasland

erlend-aasland commented Mar 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm filing this one under Pedantically Correct. I'd not expect anyone to have an installed detectable sqlite3 ever built using various defines neutering the library.

I do, I do! ✋🏻 (Mostly for testing weird stuff like this)

OTOH, we never know what kind of SQLite library will show up when we're running Python in the browser.

20 hidden items Load more…
@bedevere-bot

bedevere-bot commented Apr 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 55f79a5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 5, 2022
@arhadthedev

arhadthedev commented Apr 5, 2022

Copy link
Copy Markdown
Member

@tiran PPC64LE failure is sporadic, a rerun is required:

fatal: unable to access 'https://github.com/python/cpython.git/': Could not resolve host: github.com

@tiran

tiran commented Apr 5, 2022

Copy link
Copy Markdown
Member

@tiran PPC64LE failure is sporadic, a rerun is required:

fatal: unable to access 'python/cpython.git': Could not resolve host: github.com

The buildbot started to fail consistently two days ago. I have contacted Charris to look into the problem an hour ago.

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

16 similar comments
@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland: Status check is done, and it's a failure ❌ .

@tiran

tiran commented Apr 5, 2022

Copy link
Copy Markdown
Member

The Windows refleak, PPC64LE, and s390x issues are unrelated to the PR. The s390x issue is addressed in GH-32332.

@tiran tiran merged commit f1606a5 into python:main Apr 5, 2022
@erlend-aasland erlend-aasland deleted the ac-harden-sqlite-detection branch April 5, 2022 13:39
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
@zanieb zanieb mentioned this pull request Dec 29, 2024
Closed
@solvingj solvingj mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev requested changes

@gpshead gpshead gpshead approved these changes

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland @bedevere-bot @arhadthedev @tiran @miss-islington @gpshead @the-knights-who-say-ni