◐ Shell
reader mode source ↗
Skip to content

Remove empty footnote section#30451

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
nedbat:nedbat/remove-empty-footnotes
Mar 8, 2022
Merged

Remove empty footnote section#30451
JelleZijlstra merged 1 commit into
python:mainfrom
nedbat:nedbat/remove-empty-footnotes

Conversation

@nedbat

@nedbat nedbat commented Jan 7, 2022

Copy link
Copy Markdown
Member

There are no footnotes on this page, so no need for a "Footnotes" header.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 7, 2022
kumaraditya303
kumaraditya303 approved these changes Jan 11, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@github-actions

github-actions Bot commented Feb 11, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 11, 2022
@nedbat

nedbat commented Feb 11, 2022

Copy link
Copy Markdown
Member Author

@encukou Can we get this merged?

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 12, 2022
@kumaraditya303

kumaraditya303 commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

@JelleZijlstra This can be merged.

@JelleZijlstra JelleZijlstra self-assigned this Mar 3, 2022
@JelleZijlstra JelleZijlstra added the needs backport to 3.10 only security fixes label Mar 8, 2022
@JelleZijlstra

JelleZijlstra commented Mar 8, 2022

Copy link
Copy Markdown
Member

Going to merge this into 3.10 and main only because in the 3.9 docs there is a footnote. (cc @gvanrossum)

@JelleZijlstra JelleZijlstra merged commit 13331a1 into python:main Mar 8, 2022
@miss-islington

miss-islington commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @nedbat for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Mar 8, 2022

Copy link
Copy Markdown

GH-31745 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
@nedbat @miss-islington
importlib.metadata: Remove empty footnote section (pythonGH-30451) …
1d7c4de 
(cherry picked from commit 13331a1)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
miss-islington added a commit that referenced this pull request Mar 8, 2022
@miss-islington @nedbat
importlib.metadata: Remove empty footnote section (GH-30451) …
f6cdf5b 
(cherry picked from commit 13331a1)

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
@jaraco

jaraco commented Mar 13, 2022

Copy link
Copy Markdown
Member

This change gets overwritten when syncing the changes from importlib_metadata, such as in #31854. I can port the change to importlib_metadata so that doesn't happen, but please be cognizant of making editorial changes to importlib.metadata, importlib.resources, and the docs for importlib.metadata, as they're kept in sync with the backports. If you have any suggestions on how to guide contributors to limit these sorts of edits, please let me know.

@jaraco

jaraco commented Mar 13, 2022

Copy link
Copy Markdown
Member

Ported as python/importlib_metadata@467dba53dd48.

@nedbat nedbat deleted the nedbat/remove-empty-footnotes branch March 26, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nedbat @kumaraditya303 @JelleZijlstra @miss-islington @bedevere-bot @jaraco @the-knights-who-say-ni @AlexWaygood