bpo-46307: Add string.Template.get_identifiers() method#30493

benkehoe

Add string.Template.get_identifiers() method that returns the identifiers within the template. By default, raises an error if it encounters an invalid identifier (like substitute()). The keyword-only argument raise_on_invalid can be set to False to ignore invalid identifiers (like safe_substitute()).

https://bugs.python.org/issue46307

Automerge-Triggered-By: GH:warsaw

the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@benkehoe

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

sobolevn

Hi! Thanks for the patch!

Since this is your first PR to CPython, you would need to:

Sign CLA agreement, just follow the process in the reply above. If you have any questions - feel free to ping me 🙂
Add NEWS entry. With https://blurb-it.herokuapp.com/ or CLI tool: https://github.com/larryhastings/blurb

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

warsaw

Thanks for creating this PR!

Please be sure to update the string module's documentation too!

bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

benkehoe

I have made the requested changes; please review again

bedevere-bot

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

warsaw

@benkehoe Have you signed the CLA?

benkehoe

Do I need to put .. versionadded:: 3.11 on the new methods? I have signed the CLA. I have made the requested changes; please review again.

bedevere-bot

Thanks for making the requested changes!

@warsaw: please review the changes made to this pull request.

warsaw

Do I need to put .. versionadded:: 3.11 on the new methods?

Yes, please. Sorry, I should have mentioned that earlier.

benkehoe

Added the versionadded info to the docs.

warsaw

Thanks @benkehoe for working on this! I'm approving it. I've also set CI to run and automerge label, so if that passes, this should land.

benkehoe

Awesome! Thanks @warsaw for helping me make my first contribution to Python!

miss-islington

@benkehoe: Status check is done, and it's a success ✅ .

warsaw

Well done @benkehoe !

the-knights-who-say-ni added the CLA not signed label Jan 9, 2022

bedevere-bot added the awaiting review label Jan 9, 2022

benkehoe force-pushed the fix-issue-46307 branch from 3f90667 to fc9ac1f Compare January 9, 2022 04:38

sobolevn reviewed Jan 9, 2022

View reviewed changes

benkehoe force-pushed the fix-issue-46307 branch from fc9ac1f to 0ce4073 Compare January 9, 2022 12:42

sobolevn added the type-feature A feature request or enhancement label Jan 9, 2022

bpo-46307: Add string.Template.get_identifiers() method

319c8d7

benkehoe force-pushed the fix-issue-46307 branch from 0ce4073 to 319c8d7 Compare January 10, 2022 14:52

sobolevn reviewed Jan 10, 2022

View reviewed changes

sobolevn mentioned this pull request Jan 10, 2022

Should triage team members be allowed to "Approve GitHub Actions workflow run"? python/core-workflow#423

Closed

Update Misc/NEWS.d/next/Library/2022-01-10-07-51-43.bpo-46307.SKvOIY.rst …

b14f8bc

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

warsaw requested changes Jan 10, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Jan 10, 2022

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Jan 10, 2022

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 10, 2022

bedevere-bot requested a review from warsaw January 10, 2022 23:04

warsaw requested changes Jan 11, 2022

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting change review labels Jan 11, 2022

bpo-46307: Add string.Template.is_valid method

e80bb26

benkehoe force-pushed the fix-issue-46307 branch from 185c309 to e80bb26 Compare January 11, 2022 02:04

bpo-46307: Update documentation

f40258e

bedevere-bot added awaiting change review and removed awaiting changes labels Jan 11, 2022

bedevere-bot requested a review from warsaw January 11, 2022 03:42

bpo-46307: Update documentation

2c7e74d

warsaw added the 🤖 automerge label Jan 11, 2022

warsaw approved these changes Jan 11, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Jan 11, 2022

miss-islington merged commit dce642f into python:main Jan 11, 2022

bedevere-bot removed the awaiting merge label Jan 11, 2022

CAM-Gerlach mentioned this pull request Oct 16, 2022

gh-95913 Add string section to Whatsnew with new Template methods #98311

Merged

benkehoe mannequin mentioned this pull request Apr 10, 2022

string.Template should allow inspection of identifiers #90465

Closed

Conversation

benkehoe commented Jan 9, 2022 • edited by miss-islington Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Jan 9, 2022

CLA Missing

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

warsaw left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jan 10, 2022

Uh oh!

benkehoe commented Jan 10, 2022

Uh oh!

bedevere-bot commented Jan 10, 2022

Uh oh!

bedevere-bot commented Jan 11, 2022

Uh oh!

warsaw commented Jan 11, 2022

Uh oh!

benkehoe commented Jan 11, 2022

Uh oh!

bedevere-bot commented Jan 11, 2022

Uh oh!

warsaw commented Jan 11, 2022

Uh oh!

benkehoe commented Jan 11, 2022

Uh oh!

warsaw left a comment

Choose a reason for hiding this comment

Uh oh!

benkehoe commented Jan 11, 2022

Uh oh!

miss-islington commented Jan 11, 2022

Uh oh!

warsaw commented Jan 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benkehoe commented Jan 9, 2022 •

edited by miss-islington

Loading