◐ Shell
reader mode source ↗
Skip to content

bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494)#30494

Merged
tiran merged 2 commits into
python:mainfrom
emmatyping:fixemscripten
Jan 9, 2022
Merged

bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494)#30494
tiran merged 2 commits into
python:mainfrom
emmatyping:fixemscripten

Conversation

@emmatyping

@emmatyping emmatyping commented Jan 9, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

With the fix in 994f90c
building for Emscripten started failing with epoll link
errors as can be seen here:
https://github.com/ethanhs/python-wasm/runs/4745952720

I believe this shouldn't require a news entry.

https://bugs.python.org/issue40280

@emmatyping
bpo-40280: Fix Emscripten build config.site …
9d4553b 
With the fix in 994f90c
building for Emscripten started failing with epoll link
errors as can be seen here:
https://github.com/ethanhs/python-wasm/runs/4745952720
@sobolevn

sobolevn commented Jan 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@ethanhs should it be back-ported? 🤔

CC @corona10

@corona10

corona10 commented Jan 9, 2022

Copy link
Copy Markdown
Member

@sobolevn
Supporting WASM is a new feature from Python 3.11
I don't think that the backport is needed.

erlend-aasland
erlend-aasland approved these changes Jan 9, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

@emmatyping

emmatyping commented Jan 9, 2022

Copy link
Copy Markdown
Member Author

Yes, since this is new in 3.11 there should be no need for any backporting.

@erlend-aasland

erlend-aasland commented Jan 9, 2022

Copy link
Copy Markdown
Contributor

I'd update the PR title to more accurately reflect the actual change, though.

@emmatyping emmatyping changed the title bpo-40280: Update Emscripten build config.site Jan 9, 2022
@emmatyping
Remove out of date line from config.site …
0e96b83 
Co-authored-by: nick.pope@infogrid.io
@emmatyping emmatyping mentioned this pull request Jan 9, 2022
Closed
@tiran tiran changed the title bpo-40280: Disable epoll_create in Emscripten config.site Jan 9, 2022
@tiran tiran merged commit 5c66414 into python:main Jan 9, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

+1 more reviewer

@ngnpope ngnpope ngnpope requested changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@emmatyping @sobolevn @corona10 @erlend-aasland @tiran @ngnpope @the-knights-who-say-ni @bedevere-bot