{{ message }}
bpo-40280: Add build target for Emscripten/node.js#30495
Closed
emmatyping wants to merge 11 commits into
Closed
Conversation
Member
Sorry, something went wrong.
This adds a "python.js" target to the Makefile. We enable the raw node fs mode as suggested by @thomasballinger as it will make running the test suite under node easier, c.f. emmatyping/python-wasm#36. The wasm_asset.py script is updated to include the test module. Care is taken to skip compiling the Python files that are examples of bad syntax or encoding. This also turns on memory growth as early into the test suite I was running into OOMs.
Member
Author
|
I'm unsure if this needs a NEWS entry, I'd be happy to add one if so. |
Sorry, something went wrong.
This was referenced Jan 9, 2022
tiran
reviewed
Jan 10, 2022
Co-authored-by: Christian Heimes <christian@python.org>
emmatyping
commented
Jan 11, 2022
tiran
reviewed
Jan 11, 2022
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Member
Author
|
I think the important bits of this ended up in #30552 so this can be closed. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This adds a "python.js" target to the Makefile. We enable the raw
node.js filesystem mode as suggested by @thomasballinger as it will make running
the test suite under node easier, c.f.
emmatyping/python-wasm#36.
The
wasm_asset.pyscript is updated to include thetestmodule. Care istaken to skip compiling the Python files that are examples of bad syntax
or encoding.
This also turns on memory growth as early into the test suite I was
running into OOMs.
cc @tiran
This requires my other PR to work of course #30494(This is now merged)https://bugs.python.org/issue40280