◐ Shell
reader mode source ↗
Skip to content

bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552)#30552

Merged
tiran merged 9 commits into
python:mainfrom
tiran:bpo-40280-emscripten-targets
Jan 12, 2022
Merged

bpo-40280: Add --with-emscripten-target to build for browser or node (GH-30552)#30552
tiran merged 9 commits into
python:mainfrom
tiran:bpo-40280-emscripten-targets

Conversation

@tiran

@tiran tiran commented Jan 11, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Co-authored-by: Ethan Smith ethan@ethanhs.me
Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40280

@tiran @emmatyping
bpo-40280: Add --with-emscripten-target to build for browser or node …
b5b4504 
Co-authored-by: Ethan Smith <ethan@ethanhs.me>
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-40280-emscripten-targets branch from a1aab67 to b5b4504 Compare January 11, 2022 23:46
@brettcannon brettcannon self-requested a review January 12, 2022 01:08
emmatyping
emmatyping approved these changes Jan 12, 2022
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

@tiran

tiran commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

Two suggestions but otherwise this looks good! It is a bit unfortunate that running emmake make after the correct configure doesn't "just work" but alas.

It does now :)

@tiran tiran marked this pull request as ready for review January 12, 2022 09:01
@tiran tiran mentioned this pull request Jan 12, 2022
Closed
@tiran tiran changed the title bpo-40280: Add --with-emscripten-target to build for browser or node Jan 12, 2022
@tiran tiran merged commit 43839ba into python:main Jan 12, 2022
@tiran tiran deleted the bpo-40280-emscripten-targets branch January 12, 2022 15:08
This was referenced Jan 12, 2022
Closed
Closed
Closed
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @emmatyping @the-knights-who-say-ni @bedevere-bot