◐ Shell
reader mode source ↗
Skip to content

[3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"#30566

Closed
vstinner wants to merge 3 commits into
python:3.9from
vstinner:revert_gc39
Closed

[3.9] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"#30566
vstinner wants to merge 3 commits into
python:3.9from
vstinner:revert_gc39

Conversation

@vstinner

@vstinner vstinner commented Jan 12, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

@vstinner vstinner requested a review from pablogsal as a code owner January 12, 2022 23:02
@vstinner
bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterprete… …
2096c10 
…rState (GH-17287)"

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.
@vstinner vstinner changed the title [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 12, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Jan 12, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@bedevere-bot bedevere-bot added awaiting merge and removed labels Jan 12, 2022
@vstinner vstinner changed the title bpo-46070: [3.9] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 13, 2022
@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

Without this PR, I can crash Python in a reliable way using this method: https://bugs.python.org/issue46070#msg410447

With this PR, I can no longer reproducer the crash: Python is fixed.

@brettcannon brettcannon removed their request for review January 13, 2022 01:02
@vstinner

vstinner commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

I wrote a simpler fix: GH-30577.

@vstinner vstinner closed this Jan 13, 2022
@vstinner vstinner deleted the revert_gc39 branch January 13, 2022 18:31
@graysky graysky mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot