◐ Shell
reader mode source ↗
Skip to content

bpo-40066: [Enum] update str() and format() output#30582

Merged
ethanfurman merged 26 commits into
python:mainfrom
ethanfurman:40066-enum_output
Jan 16, 2022
Merged

bpo-40066: [Enum] update str() and format() output#30582
ethanfurman merged 26 commits into
python:mainfrom
ethanfurman:40066-enum_output

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 13, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood reopened this Jan 13, 2022
@AlexWaygood

AlexWaygood commented Jan 13, 2022

Copy link
Copy Markdown
Member

Omg, did not mean to close that at all — sorry!!

sobolevn
sobolevn reviewed Jan 14, 2022
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for your work! Enums' text representation looks way better now.

22 hidden items Load more…
@ethanfurman ethanfurman merged commit acf7403 into python:main Jan 16, 2022
@AlexWaygood

AlexWaygood commented Jan 16, 2022

Copy link
Copy Markdown
Member

This change appears to be causing CI to fail on docs for unrelated PRs ☹️ https://github.com/python/cpython/runs/4831439882?check_suite_focus=true

vstinner added a commit that referenced this pull request Jan 17, 2022
@vstinner
Revert "bpo-40066: [Enum] update str() and format() output (GH-30582)" …
7d7be71 
This reverts commit acf7403.
@vstinner vstinner mentioned this pull request Jan 17, 2022
Merged
vstinner added a commit that referenced this pull request Jan 17, 2022
@vstinner
Revert "bpo-40066: [Enum] update str() and format() output (GH-30582)" ( …
42a64c0 
GH-30632)

This reverts commit acf7403.
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 17, 2022
@kumaraditya303
Revert "Revert "bpo-40066: [Enum] update str() and format() output (p… …
39ecb6a 
…ythonGH-30582)" (pythonGH-30632)"

This reverts commit 42a64c0.
This was referenced May 23, 2022
Closed
Closed
@AdamWill

AdamWill commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

I'm curious: why does this define a __init__ for Enum which does nothing at all (just pass)?

It causes pylint to start throwing warnings about subclasses of Enum which have their own __init__ not calling super's __init__, which Python's own docs and examples don't say they should, and which of course would be pointless since it does nothing. I'm sending a PR for pylint to not emit this warning for subclasses of Enum, but I don't understand why the do-nothing __init__ was added at all.

@AdamWill AdamWill mentioned this pull request Jul 11, 2022
Merged
@DanielNoord DanielNoord mentioned this pull request Jul 14, 2022
Closed
@mdboom mdboom mentioned this pull request Oct 13, 2022
Closed
@ethanfurman ethanfurman deleted the 40066-enum_output branch November 23, 2022 23:50
This was referenced Dec 18, 2024
Closed
Merged
@hugovk hugovk mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

+1 more reviewer

@gryznar gryznar gryznar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ethanfurman @AlexWaygood @AdamWill @sobolevn @gryznar @the-knights-who-say-ni @bedevere-bot