{{ message }}
bpo-46406: Faster single digit int division.#30626
Merged
mdickinson merged 4 commits intoJan 23, 2022
Merged
Conversation
Member
Sorry, something went wrong.
This expresses the algorithm in a more basic manner resulting in better instruction generation by todays compilers. See https://mail.python.org/archives/list/python-dev@python.org/thread/ZICIMX5VFCX4IOFH5NUPVHCUJCQ4Q7QM/#NEUNFZU3TQU4CPTYZNF3WCN7DOJBBTK5
mdickinson
reviewed
Jan 22, 2022
mdickinson
reviewed
Jan 22, 2022
mdickinson
approved these changes
Jan 22, 2022
mdickinson
left a comment
mdickinson
left a comment
Member
There was a problem hiding this comment.
LGTM, modulo a cast needed to silence the compiler on Windows.
Sorry, something went wrong.
raghavthind2005
approved these changes
Jan 22, 2022
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Member
|
Still LGTM. Thank you! |
Sorry, something went wrong.
|
@mdickinson: Please replace |
Sorry, something went wrong.
tim-one
reviewed
Jan 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+2 more reviewers
6 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This expresses the algorithm in a more basic manner resulting in better
instruction generation by todays compilers.
See https://mail.python.org/archives/list/python-dev@python.org/thread/ZICIMX5VFCX4IOFH5NUPVHCUJCQ4Q7QM/#NEUNFZU3TQU4CPTYZNF3WCN7DOJBBTK5
https://bugs.python.org/issue46406