◐ Shell
reader mode source ↗
Skip to content

bpo-40066: [Enum] fix doc and unit tests#30643

Merged
ethanfurman merged 1 commit into
python:mainfrom
ethanfurman:40066-fix_tests
Jan 17, 2022
Merged

bpo-40066: [Enum] fix doc and unit tests#30643
ethanfurman merged 1 commit into
python:mainfrom
ethanfurman:40066-fix_tests

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 17, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • skip doctest that changes depending on target system
  • substitute in values that change depending on target system

https://bugs.python.org/issue40066

@ethanfurman
fix tests …
10372ae 
- skip doctest that changes depending on target system
- substitute in values that change depending on target system
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 17, 2022
@ethanfurman ethanfurman self-assigned this Jan 17, 2022
vstinner
vstinner approved these changes Jan 17, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Maybe @kulikjak wants to test it on Solaris before it's merged?

kulikjak
kulikjak approved these changes Jan 17, 2022
View reviewed changes

@kulikjak kulikjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, I quickly tested those and now it works as expected.

@vstinner

vstinner commented Jan 17, 2022

Copy link
Copy Markdown
Member

@kulikjak: I quickly tested those and now it works as expected.

Cool, thanks for testing!

@ethanfurman ethanfurman merged commit 62a6594 into python:main Jan 17, 2022
@ethanfurman

ethanfurman commented Jan 17, 2022

Copy link
Copy Markdown
Member Author

Thanks everyone for your help.

@ethanfurman ethanfurman deleted the 40066-fix_tests branch November 23, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

+1 more reviewer

@kulikjak kulikjak kulikjak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ethanfurman ethanfurman

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ethanfurman @vstinner @kulikjak @the-knights-who-say-ni @bedevere-bot