◐ Shell
reader mode source ↗
Skip to content

bpo-46425: fix direct invokation of multiple test modules#30666

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
sobolevn:issue-46425-1
Jan 18, 2022
Merged

bpo-46425: fix direct invokation of multiple test modules#30666
serhiy-storchaka merged 1 commit into
python:mainfrom
sobolevn:issue-46425-1

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Refs #30641
CC @corona10 as my mentor.

https://bugs.python.org/issue46425

I am going to mark this as "needs backport" to 3.9 and 3.10, because this is a bugfix.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Jan 18, 2022
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 1292aa6 into python:main Jan 18, 2022
@miss-islington

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the label Jan 18, 2022
@miss-islington

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.10

@miss-islington

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 1292aa6db5bed889a3c87df443754fcae0177801 3.9

@sobolevn sobolevn mentioned this pull request Jan 18, 2022
Merged
@serhiy-storchaka

serhiy-storchaka commented Jan 19, 2022

Copy link
Copy Markdown
Member

@sobolevn, do you mind to create backports manually?

@sobolevn

sobolevn commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

Sure, will do today 👍

@sobolevn sobolevn mentioned this pull request Jan 19, 2022
Merged
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
@sobolevn
[3.10] bpo-46425: Fix direct invocation of multiple test modules (pyt… …
a7a6daa 
…honGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 19, 2022
@bedevere-bot

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30699 is a backport of this pull request to the 3.10 branch.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
@sobolevn
[3.9] bpo-46425: Fix direct invocation of multiple test modules (pyth… …
50b81a2 
…onGH-30666).

(cherry picked from commit 1292aa6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot

bedevere-bot commented Jan 19, 2022

Copy link
Copy Markdown

GH-30700 is a backport of this pull request to the 3.9 branch.

@sobolevn

sobolevn commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

Done:

corona10 pushed a commit that referenced this pull request Jan 20, 2022
@sobolevn
[3.9] bpo-46425: Fix direct invocation of multiple test modules (GH-3… …
8105dd2 
…0666) (GH-30700)
corona10 pushed a commit that referenced this pull request Jan 20, 2022
@sobolevn
[3.10] bpo-46425: Fix direct invocation of multiple test modules (GH-… …
a6a0885 
…30666) (GH-30699)
@sobolevn sobolevn mentioned this pull request Apr 16, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@sobolevn @hello-adam
[3.9] bpo-46425: Fix direct invocation of multiple test modules (pyth… …
c8fae1c 
…onGH-30666) (pythonGH-30700)
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @miss-islington @serhiy-storchaka @bedevere-bot @the-knights-who-say-ni