◐ Shell
reader mode source ↗
Skip to content

bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__#30851

Merged
miss-islington merged 2 commits into
python:mainfrom
tiran:no_char_unsigned
Jan 26, 2022
Merged

bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__#30851
miss-islington merged 2 commits into
python:mainfrom
tiran:no_char_unsigned

Conversation

@tiran

@tiran tiran commented Jan 24, 2022 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46513

Automerge-Triggered-By: GH:tiran

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2022
@bedevere-bot

bedevere-bot commented Jan 24, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit ebd654724c6e3d0b528f1313b7654002eef40b52 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 24, 2022
@hroncok

hroncok commented Jan 25, 2022

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46513

@tiran tiran changed the title Test build without AC_C_CHAR_UNSIGNED Jan 25, 2022
@tiran tiran marked this pull request as ready for review January 25, 2022 11:34
hroncok
hroncok approved these changes Jan 25, 2022
View reviewed changes

@hroncok hroncok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks.

@tiran tiran added the label Jan 26, 2022
@miss-islington miss-islington merged commit 6e5a193 into python:main Jan 26, 2022
@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry, @tiran, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.10

@miss-islington miss-islington self-assigned this Jan 26, 2022
@miss-islington

miss-islington commented Jan 26, 2022

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6e5a193816e1bdf11f5fb78d620995fd6987ccf8 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 26, 2022
@bedevere-bot

bedevere-bot commented Jan 26, 2022

Copy link
Copy Markdown

GH-30914 is a backport of this pull request to the 3.10 branch.

tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2022
@tiran
[3.10] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (pyth… …
0f11817 
…onGH-30851)

(cherry picked from commit 6e5a193)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit to tiran/cpython that referenced this pull request Jan 26, 2022
@tiran
[3.9] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (pytho… …
247b9e4 
…nGH-30851)

(cherry picked from commit 6e5a193)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot

bedevere-bot commented Jan 26, 2022

Copy link
Copy Markdown

GH-30915 is a backport of this pull request to the 3.9 branch.

tiran added a commit that referenced this pull request Jan 26, 2022
@tiran
[3.10] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (GH-3… …
4371fbd 
…0851) (GH-30914)

Co-authored-by: Christian Heimes <christian@python.org>
tiran added a commit that referenced this pull request Jan 26, 2022
@tiran
[3.9] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (GH-30851 …
04772cd 
) (GH-30915)

Co-authored-by: Christian Heimes <christian@python.org>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@tiran @hello-adam
[3.9] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (pytho… …
7f6b25f 
…nGH-30851) (pythonGH-30915)

Co-authored-by: Christian Heimes <christian@python.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request May 21, 2024
@tiran @mgorny
[3.9] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (pytho… …
b6e41a0 
…nGH-30851) (pythonGH-30915)

Co-authored-by: Christian Heimes <christian@python.org>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Sep 19, 2024
@tiran @mgorny
[3.9] bpo-46513: Remove AC_C_CHAR_UNSIGNED / __CHAR_UNSIGNED__ (pytho… …
a53a55a 
…nGH-30851) (pythonGH-30915)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@ronaldoussoren ronaldoussoren ronaldoussoren left review comments

@arhadthedev arhadthedev arhadthedev left review comments

@encukou encukou encukou approved these changes

+1 more reviewer

@hroncok hroncok hroncok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@miss-islington miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@tiran @bedevere-bot @hroncok @miss-islington @vstinner @encukou @ronaldoussoren @arhadthedev @the-knights-who-say-ni