◐ Shell
reader mode source ↗
Skip to content

bpo-40170: PyType_SUPPORTS_WEAKREFS() becomes a regular function#30938

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:type_supports_weakref
Jan 27, 2022
Merged

bpo-40170: PyType_SUPPORTS_WEAKREFS() becomes a regular function#30938
vstinner merged 1 commit into
python:mainfrom
vstinner:type_supports_weakref

Conversation

@vstinner

@vstinner vstinner commented Jan 27, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Convert the PyType_SUPPORTS_WEAKREFS() macro to a regular function.
It no longer access the PyTypeObject.tp_weaklistoffset member
directly.

Add _PyType_SUPPORTS_WEAKREFS() static inline functions, used
internally by Python for best performances.

https://bugs.python.org/issue40170

@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member Author

I cannot find "PyType_SUPPORTS_WEAKREFS" in the source code of top 5000 PyPI projects.

@vstinner
bpo-40170: PyType_SUPPORTS_WEAKREFS() becomes a regular function …
b79f25a 
Convert the PyType_SUPPORTS_WEAKREFS() macro to a regular function.
It no longer access the PyTypeObject.tp_weaklistoffset member
directly.

Add _PyType_SUPPORTS_WEAKREFS() static inline functions, used
internally by Python for best performances.
@vstinner vstinner marked this pull request as ready for review January 27, 2022 01:44
@vstinner

vstinner commented Jan 27, 2022

Copy link
Copy Markdown
Member Author

This change has no impact on performance (Python internals continue accessing directly the PyTypeObject) and no impact on the API (the function remains available in the public C API).

@vstinner vstinner merged commit af32b3e into python:main Jan 27, 2022
@vstinner vstinner deleted the type_supports_weakref branch January 27, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot