bpo-46329: Reduce default recursion to 800 if Py_DEBUG is enabled.#31033
bpo-46329: Reduce default recursion to 800 if Py_DEBUG is enabled.#31033markshannon wants to merge 2 commits into
Conversation
…ack overflow on Clang debug builds.
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit b2d5700 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
I am ok to go this way if we don't manage to properly fix the issue today or tomorrow. |
Sorry, something went wrong.
|
We should also consider asking clang for more stack space as someone also suggested. |
Sorry, something went wrong.
|
I think you and I have different ideas about what "properly" is in this context. Even if #31011 had passed the tests, we would be very close to stack overflow on the clang debug build, such that any number of otherwise harmless changes could cause a stack overflow. Any "proper" fix, would need to provide a decent safety margin. Asking clang for more stack space would work, if it has such an option. |
Sorry, something went wrong.
Sorry, I think I didn't explain myself correctly. You are talking about some fix to avoid the C stack overflow but I'm taking about just getting the buildbots green without introducing any user visible changes (such as reducing the recursion depth in debug builds). The issue of resolving the stack overflow problem in general still stands and indeed is worth a more propper solution as you describe 👍 |
Sorry, something went wrong.
We use this in the mingw port for both gcc/clang: msys2-contrib@6fcebb6 to mirror a6a116c |
Sorry, something went wrong.
|
For the specific case of clang with See also https://bugs.python.org/issue46600 |
Sorry, something went wrong.
Prevents C stack overflow on Clang debug builds.
This is a temporary fix to get the buildbots working again.
This should be reverted in time for the 3.11 beta.
@pablogsal
As it looks like #31011 has failed, would this be an acceptable, temporary fix?
https://bugs.python.org/issue46329