{{ message }}
bpo-46648: move test_issue16464 to urllib2_localnet#31186
Merged
vstinner merged 1 commit intoFeb 7, 2022
Merged
Conversation
Member
Sorry, something went wrong.
gpshead
approved these changes
Feb 7, 2022
raghavthind2005
approved these changes
Feb 7, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 7, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Member
|
PR merged, thanks. I rewrote the commit title/description. |
Sorry, something went wrong.
Contributor
|
Sorry, @sobolevn and @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…erver (pythonGH-31186) Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnet and use the local HTTP server rather than an external HTTP server. (cherry picked from commit 8e98175) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewer
Assignees
8 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
I moved the flaky test to
test_urllib2_localnetas @gpshead suggested.I hope that it will now be reliable 🎉
https://bugs.python.org/issue46648