◐ Shell
reader mode source ↗
Skip to content

bpo-28261: fix err msgs where PyArg_ParseTuple is used to parse normal tuples#3119

Merged
serhiy-storchaka merged 7 commits into
python:masterfrom
orenmn:bpo28261-fix-error-msgs
Aug 20, 2017
Merged

bpo-28261: fix err msgs where PyArg_ParseTuple is used to parse normal tuples#3119
serhiy-storchaka merged 7 commits into
python:masterfrom
orenmn:bpo28261-fix-error-msgs

Conversation

@orenmn

@orenmn orenmn commented Aug 17, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

according to http://bugs.python.org/issue28261, fix some error messages.

without this patch, each of the following calls would have produced a wrong error message (at least on Windows 10):

  • ctypes.CFUNCTYPE(None)(())
  • _io.IncrementalNewlineDecoder(42, 42).setstate(())
  • audioop.ratecv(b'a', 1, 1, 42, 42, (42, ((),)))
  • audioop.lin2adpcm(b'a', 1, ())
  • audioop.adpcm2lin(b'a', 1, ())
  • _overlapped.Overlapped().ConnectEx(42, ()) (also, _overlapped.Overlapped().ConnectEx(42, 43) would have caused a SystemError.)
  • socket.getnameinfo((), 42)
  • time.strftime('aoeu', ())
  • time.asctime(())
  • time.mktime(())

https://bugs.python.org/issue28261

@serhiy-storchaka serhiy-storchaka self-requested a review August 17, 2017 18:32
@bedevere-bot

bedevere-bot commented Aug 17, 2017

Copy link
Copy Markdown

A Python core developer, serhiy-storchaka, has requested some changes be
made to your pull request before we can consider merging it. If you
could please address their requests along with any other requests in
other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment
on this pull request containing the phrase I didn't expect the Spanish Inquisition!
I will then notify serhiy-storchaka along with any other core developers
who have left a review that you're ready for them to take another look
at this pull request.

@orenmn

orenmn commented Aug 18, 2017

Copy link
Copy Markdown
Contributor Author

note that I also added very basic tests to test_audioop.py and to test_io.py, to verify SystemError is not raised anymore.

I didn't expect the Spanish Inquisition!

@bedevere-bot

bedevere-bot commented Aug 18, 2017

Copy link
Copy Markdown

Nobody expects the Spanish Inquisition!

@serhiy-storchaka: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka self-assigned this Aug 19, 2017
@serhiy-storchaka

serhiy-storchaka commented Aug 19, 2017

Copy link
Copy Markdown
Member

I think a NEWS.d entry for this PR is not required. But you can add it if you prefer.

@serhiy-storchaka serhiy-storchaka merged commit 1d1d3e9 into python:master Aug 20, 2017
This was referenced Aug 20, 2017
Closed
Merged
This was referenced Aug 26, 2017
Merged
Merged
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@orenmn @GadgetSteve
bpo-28261: Fixed err msgs where PyArg_ParseTuple is used to parse nor… …
cb67fc7 
…mal tuples. (python#3119)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orenmn @bedevere-bot @serhiy-storchaka @Mariatta @the-knights-who-say-ni