◐ Shell
reader mode source ↗
Skip to content

bpo-46494: Mention the typing_extensions pkg in typing docs#31260

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
meersuri:fix-issue-46494
Mar 8, 2022
Merged

bpo-46494: Mention the typing_extensions pkg in typing docs#31260
JelleZijlstra merged 4 commits into
python:mainfrom
meersuri:fix-issue-46494

Conversation

@meersuri

@meersuri meersuri commented Feb 10, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Feb 10, 2022
@JelleZijlstra JelleZijlstra self-requested a review February 10, 2022 14:46
sobolevn
sobolevn reviewed Feb 10, 2022
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you 🚀

JelleZijlstra
JelleZijlstra requested changes Feb 11, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Could you apply Nikita's and my suggestions?

@meersuri

meersuri commented Feb 11, 2022 via email

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra JelleZijlstra self-assigned this Feb 19, 2022
@bedevere-bot

bedevere-bot commented Mar 2, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@meersuri

meersuri commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Mar 2, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

JelleZijlstra
JelleZijlstra approved these changes Mar 3, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks! @gvanrossum planning to merge this typing docs change

14 hidden items Load more…
Fidget-Spinner
Fidget-Spinner approved these changes Mar 4, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM too.

@JelleZijlstra JelleZijlstra merged commit 8debeed into python:main Mar 8, 2022
@miss-islington

miss-islington commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @meersuri for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @meersuri for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
@meersuri @miss-islington
bpo-46494: Mention the typing_extensions pkg in typing docs (pythonGH… …
b8591a7 
…-31260)

(cherry picked from commit 8debeed)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2022
@meersuri @miss-islington
bpo-46494: Mention the typing_extensions pkg in typing docs (pythonGH… …
e306a0e 
…-31260)

(cherry picked from commit 8debeed)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Mar 8, 2022

Copy link
Copy Markdown

GH-31746 is a backport of this pull request to the 3.9 branch.

@bedevere-bot

bedevere-bot commented Mar 8, 2022

Copy link
Copy Markdown

GH-31747 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Mar 8, 2022
@miss-islington @meersuri
bpo-46494: Mention the typing_extensions pkg in typing docs (GH-31260) …
e053f0e 
(cherry picked from commit 8debeed)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 8, 2022
@miss-islington @meersuri
bpo-46494: Mention the typing_extensions pkg in typing docs (GH-31260) …
0c718e0 
(cherry picked from commit 8debeed)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @meersuri @hello-adam
bpo-46494: Mention the typing_extensions pkg in typing docs (pythonGH… …
320ebf5 
…-31260)

(cherry picked from commit 8debeed)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@meersuri @bedevere-bot @miss-islington @JelleZijlstra @gvanrossum @sobolevn @Fidget-Spinner @the-knights-who-say-ni @AlexWaygood