bpo-46711: increase timeout for test_logging::test_post_fork_child_no_deadlock#31274
bpo-46711: increase timeout for test_logging::test_post_fork_child_no_deadlock#31274sobolevn wants to merge 3 commits into
test_logging::test_post_fork_child_no_deadlock#31274Conversation
|
Oh. I forgot that I doubled the ASAN buildbot last week: python/buildmaster-config@5a37411
So SHORT_TIMEOUT should now be 60 seconds rather than 30 seconds. Why did https://buildbot.python.org/all/#/builders/621/builds/466 fail at 52.5 seconds seconds in this case? Maybe my computation is wrong, or this build is older than the buildbot configuration change? |
Sorry, something went wrong.
|
I'm ok not changing the default. I'm convinced by @sobolevn comments 👍 |
Sorry, something went wrong.
I have no idea. I checked and the builder should have picked the change you talk about but maybe I have missed something :( |
Sorry, something went wrong.
I've added the information about the timeout to the error message. It can probably help the next time we have the same problem. |
Sorry, something went wrong.
@sobolevn No worries! I don't mind not getting credit. :) This was just a minor thing I noticed while working on #30310. |
Sorry, something went wrong.
vstinner
left a comment
There was a problem hiding this comment.
The Lib/test/support/init.py change is nice. I'm no longer sure that the Lib/test/test_logging.py change is correct. Maybe revert test_logging.py change?
Sorry, something went wrong.
Closes #31205
Thank you, @notarealdeveloper for noticing it!
However, I am not sure how to proceed here:
https://bugs.python.org/issue46711