{{ message }}
bpo-30830: test_logging: don't use daemon threads#3135
Closed
vstinner wants to merge 3 commits into
Closed
Conversation
Member
Sorry, something went wrong.
test_logging: * Don't use daemon threads, but regular threads * Replace hardcoded literal constants with a new STOP_TIMEOUT constant. * Fix servers: don't call fail() since the method doesn't exist, but raise directly an AssertionError
Wait 60 seconds rather than 2 seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
test_logging:
constant.
raise directly an AssertionError
https://bugs.python.org/issue30830