{{ message }}
bpo-46841: Use *inline* caching for BINARY_OP#31543
Merged
markshannon merged 8 commits intoFeb 25, 2022
Merged
Conversation
Member
Sorry, something went wrong.
markshannon
reviewed
Feb 24, 2022
markshannon
reviewed
Feb 24, 2022
markshannon
reviewed
Feb 24, 2022
markshannon
reviewed
Feb 24, 2022
markshannon
reviewed
Feb 24, 2022
Member
|
Looks good in general. |
Sorry, something went wrong.
brandtbucher
added
the
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
label
Feb 24, 2022
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 1aa079c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
bedevere-bot
removed
the
🔨 test-with-buildbots
Test PR w/ buildbots; report in status section
label
Feb 24, 2022
Member
|
👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Here's a sort-of-rough first pass at implementing this idea.
BINARY_OPis easy to start with, since it only uses its cache for the adaptivecountermember. Initial perf testing doesn't show any impact, which I think is good (it means that the basic idea works well, even when the cache isn't being used).Related changes:
disutilities grow ashow_cachesparameter, defaulting toFalse.wordcode_helpers.hhas been moved intocompile.c.https://bugs.python.org/issue46841