bpo-46841: Move the cache for LOAD_GLOBAL inline.#31575
Conversation
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 26d0d70 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
|
Performance is underwhelming. What is notable is that the number of |
Sorry, something went wrong.
Yeah, I suspect we may not see a ton of payoff until we convert most/all of the caches. |
Sorry, something went wrong.
brandtbucher
left a comment
There was a problem hiding this comment.
A few things:
- The magic number needs to be bumped every time we do this.
- I thought we decided to use
_Py_CODEUNITeverywhere you're usinguint16_tnow (it may also be worth adding_Py_TWOCODEUNITSand_Py_FOURCODEUNITSaliases foruint32_tanduintptr_t, respectively).
Sorry, something went wrong.
|
When you're done making the requested changes, leave the comment: |
Sorry, something went wrong.
👍
Hmm, I'd prefer not. Versions, for example, are 32 bit value, not 2 code units. If the size of the Maybe we should give up on the pretense that the size of the code unit can be easily changed, and replace |
Sorry, something went wrong.
Also removes duplication of the
_PyOpcode_InlineCacheEntriestable.https://bugs.python.org/issue46841