◐ Shell
reader mode source ↗
Skip to content

bpo-46541: remove usage of _Py_IDENTIFIER from _ssl module#31599

Merged
corona10 merged 2 commits into
python:mainfrom
kumaraditya303:ssl-id
Mar 1, 2022
Merged

bpo-46541: remove usage of _Py_IDENTIFIER from _ssl module#31599
corona10 merged 2 commits into
python:mainfrom
kumaraditya303:ssl-id

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Feb 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland
erlend-aasland approved these changes Feb 26, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

lgtm

@corona10

corona10 commented Feb 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I assigned core devs who are highly involved in this issue. cc @erlend-aasland
We may need to wait for some decision before we merge this PR as same as #31475

@dwvshell

This comment was marked as off-topic.

Sign in to view
@bedevere-bot

bedevere-bot commented Feb 27, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tiran tiran removed the skip news label Feb 27, 2022
@kumaraditya303

kumaraditya303 commented Feb 28, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Feb 28, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from tiran February 28, 2022 07:15
corona10
corona10 approved these changes Mar 1, 2022
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM
see my decision: #31475 (comment)
I am waiting for @tiran 's decision since he is the maintainer of the SSL module.

@corona10 corona10 merged commit e91b0a7 into python:main Mar 1, 2022
@kumaraditya303 kumaraditya303 deleted the ssl-id branch March 1, 2022 17:16
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@vstinner vstinner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kumaraditya303 @corona10 @dwvshell @bedevere-bot @tiran @erlend-aasland @the-knights-who-say-ni