◐ Shell
reader mode source ↗
Skip to content

[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)#31634

Merged
vstinner merged 3 commits into
python:3.10from
vstinner:skip_asan310
Mar 2, 2022
Merged

[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)#31634
vstinner merged 3 commits into
python:3.10from
vstinner:skip_asan310

Conversation

@vstinner

@vstinner vstinner commented Mar 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Skip tests on ASAN and/or MSAN builds:

  • multiprocessing tests
  • test___all__
  • test_concurrent_futures
  • test_decimal
  • test_peg_generator
  • test_tools

(cherry picked from commit 9204bb7)

https://bugs.python.org/issue46633

@vstinner vstinner changed the title bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) Mar 1, 2022
pablogsal and others added 3 commits March 1, 2022 18:14
@pablogsal @vstinner
Refactor sanitiser skip tests into test.support (GH-30889) …
1728982 
* Refactor sanitizer skip tests into test.support

* fixup! Refactor sanitizer skip tests into test.support

* fixup! fixup! Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)
@pablogsal @vstinner
Add skips to crashing tests under sanitizers instead of manually skip… …
cd983cc 
…ping them (GH-30897)

(cherry picked from commit a275053)
@vstinner
bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) …
a2734a5 
Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)
@vstinner

vstinner commented Mar 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member Author

I rewrote the PR to backport 3 changes rather than just 1:

@vstinner vstinner merged commit 9326445 into python:3.10 Mar 2, 2022
@miss-islington

miss-islington commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@vstinner vstinner deleted the skip_asan310 branch March 2, 2022 16:05
@miss-islington

miss-islington commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 93264452d952d9ba604bacf2947c2df5dd477931 3.9

@bedevere-bot

bedevere-bot commented Mar 2, 2022

Copy link
Copy Markdown

GH-31644 is a backport of this pull request to the 3.9 branch.

vstinner added a commit that referenced this pull request Mar 2, 2022
@vstinner @pablogsal
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) (G… …
359bc39 
…H-31634) (GH-31644)

* Refactor sanitiser skip tests into test.support (GH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
(cherry picked from commit 9326445)
@vstinner vstinner mentioned this pull request May 5, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@vstinner @pablogsal @hello-adam
[3.10] bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632… …
c36f6d7 
…) (pythonGH-31634) (pythonGH-31644)

* Refactor sanitiser skip tests into test.support (pythonGH-30889)

* Refactor sanitizer skip tests into test.support

(cherry picked from commit b1cb843)

* Add skips to crashing tests under sanitizers instead of manually skipping them (pythonGH-30897)

(cherry picked from commit a275053)

* bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632)

Skip tests on ASAN and/or MSAN builds:

* multiprocessing tests
* test___all__
* test_concurrent_futures
* test_decimal
* test_peg_generator
* test_tools

(cherry picked from commit 9204bb7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
(cherry picked from commit 9326445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni @pablogsal