◐ Shell
reader mode source ↗
Skip to content

bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module#31683

Merged
corona10 merged 1 commit into
python:mainfrom
corona10:bpo-46430-lzma
Mar 4, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from lzma module#31683
corona10 merged 1 commit into
python:mainfrom
corona10:bpo-46430-lzma

Conversation

@corona10

@corona10 corona10 commented Mar 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@kumaraditya303

kumaraditya303 commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Wrong bpo number ?

erlend-aasland
erlend-aasland approved these changes Mar 4, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Check bpo number; else looks good to me.

kumaraditya303
kumaraditya303 approved these changes Mar 4, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@corona10 corona10 changed the title bpo-46430: Remove usage of _Py_IDENTIFIER from lzma module Mar 4, 2022
@corona10

corona10 commented Mar 4, 2022

Copy link
Copy Markdown
Member Author

I will merge this PR once the adding label is available, it looks like the outage situation.

ericsnowcurrently
ericsnowcurrently approved these changes Mar 4, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@corona10 corona10 merged commit d168c72 into python:main Mar 4, 2022
@corona10 corona10 deleted the bpo-46430-lzma branch March 4, 2022 16:38
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@corona10 @kumaraditya303 @ericsnowcurrently @erlend-aasland @the-knights-who-say-ni @bedevere-bot