{{ message }}
bpo-31243: fix PyArg_ParseTuple failure checks#3171
Merged
serhiy-storchaka merged 6 commits intoAug 29, 2017
Merged
Conversation
Contributor
Sorry, something went wrong.
orenmn
commented
Aug 22, 2017
Member
|
Please add also a NEWS.d entry. This change fixes bugs and the information about this can be important for end users. |
Sorry, something went wrong.
Contributor
Author
|
please ignore this NEWS.d. it is not accurate. I would fix it soon. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Aug 28, 2017
serhiy-storchaka
added
needs backport to 2.7
type-bug
An unexpected behavior, bug, or error
labels
Aug 29, 2017
orenmn
added a commit
to orenmn/cpython
that referenced
this pull request
Aug 29, 2017
(cherry picked from commit ba7d736)
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 29, 2017
GadgetSteve
pushed a commit
to GadgetSteve/cpython
that referenced
this pull request
Sep 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
according to http://bugs.python.org/issue31243, replace checks whether PyArg_ParseTuple returned a negative value with checks whether PyArg_ParseTuple returned 0.
while we are here, make sure the call to PyArg_ParseTuple in textiowrapper_read_chunk() won't cause producing a wrong error message, as explained in http://bugs.python.org/issue28261, or a SystemError.
https://bugs.python.org/issue31243